-
Notifications
You must be signed in to change notification settings - Fork 309
ui: Add "inbox" view #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As a first pass at least, I plan to implement this design for the screen: https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=442%3A18163&mode=dev ![]() Unless @terpimost would prefer something different. |
@terpimost, can you point me to a specification for how to compute those stream-specific colors from a base stream color in the user data? Otherwise in this first pass I won't implement stream colors. |
Oh! Never mind; I see this was answered in chat in August: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20.23F117.20.22Inbox.22.20screen/near/1624484 I've just resumed that conversation with another question I had about the design. |
We'll use this to follow the Figma spec for the Inbox view, zulip#117.
From logging, this would otherwise be 0xfffefbff. See the Flutter doc on ColorScheme.background: https://api.flutter.dev/flutter/material/ColorScheme/background.html It simply says: > A color that typically appears behind scrollable content. This change is definitely the boldest we've been in perceiving a pattern in the Figma spec and organizing our code to fit it. We should cheerfully do something else if it turns out to make it harder instead of easier to follow the spec. Prompted by noticing that the surface underneath the scrollable content in RecentDmConversationsPage wasn't colored according to the Figma. And that the Figma's design for the Inbox page (zulip#117) had the same color for the surface underneath *its* scrollable content. This change fixes the RecentDmConversationsPage and makes it easy and natural for the Inbox page to get the right color too.
We'll use this to follow the Figma spec for the Inbox view, zulip#117.
From logging, this would otherwise be 0xfffefbff. See the Flutter doc on ColorScheme.background: https://api.flutter.dev/flutter/material/ColorScheme/background.html It simply says: > A color that typically appears behind scrollable content. This change is definitely the boldest we've been in perceiving a pattern in the Figma spec and organizing our code to fit it. We should cheerfully do something else if it turns out to make it harder instead of easier to follow the spec. Prompted by noticing that the surface underneath the scrollable content in RecentDmConversationsPage wasn't colored according to the Figma. And that the Figma's design for the Inbox page (zulip#117) had the same color for the surface underneath *its* scrollable content. This change fixes the RecentDmConversationsPage and makes it easy and natural for the Inbox page to get the right color too.
From logging, this would otherwise be 0xfffefbff. See the Flutter doc on ColorScheme.background: https://api.flutter.dev/flutter/material/ColorScheme/background.html It simply says: > A color that typically appears behind scrollable content. This change is definitely the boldest we've been in perceiving a pattern in the Figma spec and organizing our code to fit it. We should cheerfully do something else if it turns out to make it harder instead of easier to follow the spec. Prompted by noticing that the surface underneath the scrollable content in RecentDmConversationsPage wasn't colored according to the Figma. And that the Figma's design for the Inbox page (zulip#117) had the same color for the surface underneath *its* scrollable content. This change fixes the RecentDmConversationsPage and makes it easy and natural for the Inbox page to get the right color too.
From logging, this would otherwise be 0xfffefbff. See the Flutter doc on ColorScheme.background: https://api.flutter.dev/flutter/material/ColorScheme/background.html It simply says: > A color that typically appears behind scrollable content. This change is definitely the boldest we've been in perceiving a pattern in the Figma spec and organizing our code to fit it. We should cheerfully do something else if it turns out to make it harder instead of easier to follow the spec. Prompted by noticing that the surface underneath the scrollable content in RecentDmConversationsPage wasn't colored according to the Figma. And that the Figma's design for the Inbox page (zulip#117) had the same color for the surface underneath *its* scrollable content. This change fixes the RecentDmConversationsPage and makes it easy and natural for the Inbox page to get the right color too.
Like the "Home" tab /
UnreadCards
inzulip-mobile
.The text was updated successfully, but these errors were encountered: