-
Notifications
You must be signed in to change notification settings - Fork 309
Show message reactions #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Aug 3, 2023
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Aug 3, 2023
Ongoing discussion about how to handle these: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20reaction.20events/near/1619282 But for now, at least we can represent the events in the API model, before we handle them. Related: zulip#121
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Aug 3, 2023
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Aug 3, 2023
Ongoing discussion about how to handle these: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20reaction.20events/near/1619282 But for now, at least we can represent the events in the API model, before we handle them. Related: zulip#121
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Aug 4, 2023
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Aug 7, 2023
From studying the web app's layout and the mobile app's current widget tree, I think the right place in that tree for a "reactions" row would be here (marked Code/// A Zulip message, showing the sender's name and avatar.
class MessageWithSender extends StatelessWidget {
const MessageWithSender(
{super.key, required this.message, required this.content});
final Message message;
final ZulipContent content;
@override
Widget build(BuildContext context) {
final time = _kMessageTimestampFormat
.format(DateTime.fromMillisecondsSinceEpoch(1000 * message.timestamp));
return GestureDetector(
behavior: HitTestBehavior.translucent,
onLongPress: () => showMessageActionSheet(context: context, message: message),
// TODO clean up this layout, by less precisely imitating web
child: Padding(
padding: const EdgeInsets.only(top: 2, bottom: 3, left: 8, right: 8),
child: Row(crossAxisAlignment: CrossAxisAlignment.start, children: [
Padding(
padding: const EdgeInsets.fromLTRB(3, 6, 11, 0),
child: Avatar(userId: message.senderId, size: 35, borderRadius: 4)),
Expanded(
child: Column(
crossAxisAlignment: CrossAxisAlignment.stretch,
children: [
const SizedBox(height: 3),
Text(message.senderFullName, // TODO get from user data
style: const TextStyle(fontWeight: FontWeight.bold)),
const SizedBox(height: 4),
MessageContent(message: message, content: content),
// <-- here
])),
Container(
width: 80,
padding: const EdgeInsets.only(top: 4, right: 2),
alignment: Alignment.topRight,
child: Text(time, style: _kMessageTimestampStyle)),
])));
}
} Greg, are you aware of any problems with putting it there, or conflicts with your work on #174 / #175? |
This was referenced Aug 15, 2023
77 tasks
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Nov 22, 2023
And also support: - removing a reaction you've already made, and - joining in on existing reactions that other people have made. It leaves out one part of zulip#125, for now: - joining in on an existing reaction other people have made As is our habit with the message list, this aims to be faithful to the web app, as accessed today. That should be a good baseline to make mobile-specific adjustments from. (In particular I think we'll want larger touch targets.) Unlike the web app, we use a font instead of a sprite sheet to render Unicode emoji. This means that we, unlike web, have to account for text-layout algorithms, and things like font metrics. So if Unicode emoji appear noticeably differently from web, that's worth being aware of. Fixes: zulip#121 Fixes-partly: zulip#125
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Nov 27, 2023
And also support: - removing a reaction you've already made, and - joining in on existing reactions that other people have made. As is our habit with the message list, this aims to be faithful to the web app, as accessed today. That should be a good baseline to make mobile-specific adjustments from. (In particular I think we'll want larger touch targets.) Unlike the web app, we use a font instead of a sprite sheet to render Unicode emoji. This means that we, unlike web, have to account for text-layout algorithms, and things like font metrics. So if Unicode emoji appear noticeably differently from web, that's worth being aware of. Fixes: zulip#121 Fixes-partly: zulip#125
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Nov 30, 2023
And also support: - removing a reaction you've already made, and - joining in on existing reactions that other people have made. As is our habit with the message list, this aims to be faithful to the web app, as accessed today. That should be a good baseline to make mobile-specific adjustments from. (In particular I think we may want larger touch targets.) Unlike the web app, we use a font instead of a sprite sheet to render Unicode emoji. This means that we, unlike web, have to account for text-layout algorithms, and things like font metrics. So if Unicode emoji appear noticeably differently from web, that probably has something to do with it. Fixes: zulip#121 Fixes-partly: zulip#125
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Nov 30, 2023
And also support: - removing a reaction you've already made, and - joining in on existing reactions that other people have made. As is our habit with the message list, this aims to be faithful to the web app, as accessed today. That should be a good baseline to make mobile-specific adjustments from. (In particular I think we may want larger touch targets.) Unlike the web app, we use a font instead of a sprite sheet to render Unicode emoji. This means that we, unlike web, have to account for text-layout algorithms, and things like font metrics. So if Unicode emoji appear noticeably differently from web, that probably has something to do with it. Fixes: zulip#121 Fixes-partly: zulip#125
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Dec 1, 2023
And also support: - removing a reaction you've already made, and - joining in on existing reactions that other people have made. As is our habit with the message list, this aims to be faithful to the web app, as accessed today. That should be a good baseline to make mobile-specific adjustments from. (In particular I think we may want larger touch targets.) Unlike the web app, we use a font instead of a sprite sheet to render Unicode emoji. This means that we, unlike web, have to account for text-layout algorithms, and things like font metrics. So if Unicode emoji appear noticeably differently from web, that probably has something to do with it. Fixes: zulip#121 Fixes-partly: zulip#125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This should include handling events that add and remove reactions.
The text was updated successfully, but these errors were encountered: