Skip to content

ui: Allow selecting a different dark/light-theme setting than device setting #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisbobbe opened this issue Dec 27, 2024 · 1 comment · Fixed by #1167
Closed

ui: Allow selecting a different dark/light-theme setting than device setting #1216

chrisbobbe opened this issue Dec 27, 2024 · 1 comment · Fixed by #1167
Labels
beta feedback Things beta users have specifically asked for
Milestone
M5b: Launch goals

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 27, 2024 •
edited
Loading

From beta feedback:

The beta is great, especially the responsiveness compared to the old app. Just a minor question - is there a way to turn off dark mode, despite it being my OS setting?

Currently, the app UI follows the device setting for dark/light theme.

This issue is for an in-app setting to choose one or the other for the app, independently of the device setting.

An instance of:
@chrisbobbe chrisbobbe added the beta feedback Things beta users have specifically asked for label Dec 27, 2024
@chrisbobbe chrisbobbe mentioned this issue Dec 27, 2024
Closed
@chrisbobbe
Copy link
Collaborator Author

As I noted on #1139:

Storing some client settings is #97, and I see a core team member (@PIG208) has just self-assigned that issue. So let's wait to work on this until he implements a settings UI where this setting will go.

The same applies here.

@gnprice gnprice added this to the M5: Launch milestone Dec 27, 2024
@chrisbobbe chrisbobbe mentioned this issue Feb 25, 2025
Merged
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Feb 25, 2025
@PIG208
settings: Add settings page with vanilla Flutter widgets
41181e3 
This does not aim to fully implement the wip design for the settings
page.  We offer it mainly to test settings, so the implementation is
kept as simple as possible.

WIP design:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=446-21372&t=BZKpTQPSiBDNxwvB-0

Fixes: zulip#1216

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 4, 2025
@PIG208
settings: Add settings page with vanilla Flutter widgets
5b8edb8 
This does not aim to fully implement the wip design for the settings
page.  We offer it mainly to test settings, so the implementation is
kept as simple as possible.

WIP design:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=446-21372&t=BZKpTQPSiBDNxwvB-0

Fixes: zulip#1216

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 4, 2025
@PIG208
settings: Add settings page with vanilla Flutter widgets
902c8a6 
This does not aim to fully implement the wip design for the settings
page.  We offer it mainly to test settings, so the implementation is
kept as simple as possible.

WIP design:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=446-21372&t=BZKpTQPSiBDNxwvB-0

Fixes: zulip#1216

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 4, 2025
@PIG208
settings: Add settings page with vanilla Flutter widgets
24eba9e 
This does not aim to fully implement the wip design for the settings
page.  We offer it mainly to test settings, so the implementation is
kept as simple as possible.

WIP design:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=446-21372&t=BZKpTQPSiBDNxwvB-0

Fixes: zulip#1216

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 5, 2025
@PIG208
settings: Add settings page with vanilla Flutter widgets
ce62085 
This does not aim to fully implement the wip design for the settings
page.  We offer it mainly to test settings, so the implementation is
kept as simple as possible.

WIP design:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=446-21372&t=BZKpTQPSiBDNxwvB-0

Fixes: zulip#1216

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 5, 2025
@PIG208
settings: Add settings page with vanilla Flutter widgets
f17f46a 
This does not aim to fully implement the wip design for the settings
page.  We offer it mainly to test settings, so the implementation is
kept as simple as possible.

WIP design:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=446-21372&t=BZKpTQPSiBDNxwvB-0

Fixes: zulip#1216

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 6, 2025
@PIG208
settings: Add settings page with vanilla Flutter widgets
197ac45 
This does not aim to fully implement the wip design for the settings
page.  We offer it mainly to test settings, so the implementation is
kept as simple as possible.

WIP design:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=446-21372&t=BZKpTQPSiBDNxwvB-0

Fixes: zulip#1216

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 6, 2025
@PIG208
settings: Add settings page with vanilla Flutter widgets
91992c2 
This does not aim to fully implement the wip design for the settings
page.  We offer it mainly to test settings, so the implementation is
kept as simple as possible.

WIP design:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=446-21372&t=BZKpTQPSiBDNxwvB-0

Fixes: zulip#1216

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 10, 2025
@PIG208
settings: Add settings page with vanilla Flutter widgets
fc207d1 
This does not aim to fully implement the wip design for the settings
page.  We offer it mainly to test settings, so the implementation is
kept as simple as possible.

WIP design:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=446-21372&t=BZKpTQPSiBDNxwvB-0

Fixes: zulip#1216

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 11, 2025
@PIG208
settings: Add settings page with vanilla Flutter widgets
ed0afcb 
This does not aim to fully implement the wip design for the settings
page.  We offer it mainly to test settings, so the implementation is
kept as simple as possible.

Old design for reference:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=446-21372&t=BZKpTQPSiBDNxwvB-0

Fixes: zulip#1216

Signed-off-by: Zixuan James Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta feedback Things beta users have specifically asked for
Projects
Flutter app
Status: Done
Milestone
M5b: Launch goals
Development

Successfully merging a pull request may close this issue.

Support some client settings; add settings page PIG208/zulip-flutter
2 participants
@gnprice @chrisbobbe