Skip to content

Offer mark-as-unread #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gnprice opened this issue May 26, 2023 · 0 comments · Fixed by #779
Closed

Offer mark-as-unread #131

gnprice opened this issue May 26, 2023 · 0 comments · Fixed by #779
Assignees
@Khader-1
Labels
a-api Implementing specific parts of the Zulip server API a-msglist The message-list screen, except what's label:a-content
Milestone
M3: Summer 2024

Comments

@gnprice
Copy link
Member

gnprice commented May 26, 2023

This is the feature to mark the messages in the current narrow as unread, starting from a given message. The UI for this will be in the long-press menu on the message.

Prerequisite:

Related but different:
@gnprice gnprice added m-alpha a-msglist The message-list screen, except what's label:a-content a-api Implementing specific parts of the Zulip server API labels May 26, 2023
@gnprice gnprice added this to the Alpha milestone May 27, 2023
@gnprice gnprice removed the m-alpha label May 27, 2023
@gnprice gnprice modified the milestones: Alpha, Launch Sep 22, 2023
@gnprice gnprice mentioned this issue May 8, 2024
Open
@gnprice gnprice modified the milestones: Launch, B2: Summer 2024 May 9, 2024
@Khader-1 Khader-1 self-assigned this Jul 11, 2024
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 11, 2024
@Khader-1
action_sheet: Add Mark as unread from here button
fa7c150 
Fixes: zulip#131
@Khader-1 Khader-1 mentioned this issue Jul 11, 2024
Merged
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 13, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
550011c 
Fixes zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 15, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
b5da0c8 
Fixes zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 17, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
5215bd6 
Fixes: zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 18, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
64f3451 
Fixes: zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 18, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
1abcafe 
Fixes: zulip#131
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jul 19, 2024
@gnprice
actions [nfc]: Move markNarrowAsRead to new file
40674c3 
This function isn't quite part of the UI -- it's mostly a driver
around some API requests.  But it doesn't belong in the API code
either, because it interacts with UI widgets in order to give
progress and failure feedback to the user.

Because there's nontrivial logic in here and it isn't really specific
to this particular piece of UI, we'd like to reuse much of this code,
in particular for zulip#131 marking as unread (as discussed at zulip#779).
This new file provides an appropriate home for that reusable code.

Before we can actually reuse this for marking as unread, it'll need
some refactoring.  Before we undertake refactoring it, it should have
tests that operate at the layer of this function itself, so that they
can easily be adapted to cover the mark-unread case too.  There are
existing tests that cover this pretty thoroughly, but they act on the
UI in the message list that drives it.  So we'll port those tests over
in the next couple of commits.
@gnprice gnprice mentioned this issue Jul 19, 2024
Merged
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jul 19, 2024
@gnprice
actions [nfc]: Move markNarrowAsRead to new file
f2e182a 
This function isn't quite part of the UI -- it's mostly a driver
around some API requests.  But it doesn't belong in the API code
either, because it interacts with UI widgets in order to give
progress and failure feedback to the user.

Because there's nontrivial logic in here and it isn't really specific
to this particular piece of UI, we'd like to reuse much of this code,
in particular for zulip#131 marking as unread (as discussed at zulip#779).
This new file provides an appropriate home for that reusable code.

Before we can actually reuse this for marking as unread, it'll need
some refactoring.  Before we undertake refactoring it, it should have
tests that operate at the layer of this function itself, so that they
can easily be adapted to cover the mark-unread case too.  There are
existing tests that cover this pretty thoroughly, but they act on the
UI in the message list that drives it.  So we'll port those tests over
in the next couple of commits.
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 21, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
22cdbf0 
Fixes: zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 23, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
e5394fb 
Fixes: zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 26, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
b6724c7 
Fixes: zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 30, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
d3133a8 
Fixes: zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 7, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
ce72213 
Fixes: zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 8, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
a5525e7 
Fixes: zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 9, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
3fc179a 
Fixes: zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 12, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
6fb299a 
Fixes: zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 12, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
2f5ec06 
Fixes: zulip#131
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 12, 2024
@Khader-1
action_sheet: Add "Mark as unread from here" button
3360063 
Fixes: zulip#131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Khader-1 Khader-1

Labels
a-api Implementing specific parts of the Zulip server API a-msglist The message-list screen, except what's label:a-content
Projects
Flutter app
Status: Done
Milestone
M3: Summer 2024
Development

Successfully merging a pull request may close this issue.

action_sheet: Add "Mark as unread from here" button Khader-1/zulip-flutter
2 participants
@gnprice @Khader-1