Skip to content

Handle headings <h1>…<h5>, as well as <h6> #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #309
gnprice opened this issue Jun 15, 2023 · 0 comments · Fixed by #492
Closed
Tracked by #309

Handle headings <h1>…<h5>, as well as <h6> #192

gnprice opened this issue Jun 15, 2023 · 0 comments · Fixed by #492
Assignees
@sirpengi
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents beta feedback Things beta users have specifically asked for
Milestone
M2: Beta 2, Sprin...

Comments

@gnprice
Copy link
Member

gnprice commented Jun 15, 2023 •
edited
Loading

Currently the prototype handles <h6> elements, but not headings of higher levels <h5> up to <h1>. We should handle the higher-level headings too.

This means parsing them in lib/model/content.dart, and then styling them appropriately in lib/widgets/content.dart.

For appropriate styling, see the Zulip web app's web/styles/rendered_markdown.css.
@gnprice gnprice added the a-content Parsing and rendering Zulip HTML content, notably message contents label Jun 15, 2023
@gnprice gnprice added this to the Beta milestone Jun 15, 2023
gnprice added a commit that referenced this issue Jun 15, 2023
@gnprice
content [nfc]: Convert content parsing/rendering TODOs to issues
b79bd77 
Filed #191, #192, #193, #194.
@gnprice gnprice mentioned this issue Sep 22, 2023
Closed
9 tasks
@gnprice gnprice modified the milestones: Beta 1, Beta 2 Nov 8, 2023
@gnprice gnprice modified the milestones: Beta 2, Beta 3 Nov 22, 2023
@gnprice gnprice modified the milestones: Beta 3, Beta 2 Dec 23, 2023
@gnprice gnprice added the beta feedback Things beta users have specifically asked for label Dec 23, 2023
@sirpengi sirpengi self-assigned this Jan 11, 2024
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Jan 25, 2024
@sirpengi
content: Implement h1-h5
38c40ad 
Fixes: zulip#192
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Jan 25, 2024
@sirpengi
content: Implement h1-h5
5be82b9 
Fixes: zulip#192
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Jan 29, 2024
@sirpengi
content: Implement h1-h5
0ec82ce 
Fixes: zulip#192
@sirpengi sirpengi mentioned this issue Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirpengi sirpengi

Labels
a-content Parsing and rendering Zulip HTML content, notably message contents beta feedback Things beta users have specifically asked for
Projects
Flutter app
Status: Done
Milestone
M2: Beta 2, Spring 2024
Development

Successfully merging a pull request may close this issue.

Implement h1-h5 sirpengi/zulip-flutter
2 participants
@gnprice @sirpengi