Skip to content

autocomplete: Add user avatars to user-mention autocompletes #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisbobbe opened this issue Jul 19, 2023 · 2 comments · Fixed by #590
Closed

autocomplete: Add user avatars to user-mention autocompletes #227

chrisbobbe opened this issue Jul 19, 2023 · 2 comments · Fixed by #590
Assignees
Labels
a-compose Compose box, autocomplete, attaching files/images

Comments

@chrisbobbe
Copy link
Collaborator

No description provided.

@gnprice gnprice added the a-compose Compose box, autocomplete, attaching files/images label Jul 19, 2023
@gnprice gnprice added this to the Beta milestone Jul 19, 2023
@gnprice gnprice modified the milestones: Beta 1, Beta 2 Nov 8, 2023
@gnprice gnprice modified the milestones: Beta 2, Beta 3 Nov 22, 2023
@sm-sayedi
Copy link
Collaborator

I would like to work on this issue!

So far, my work looks like this:

@gnprice
Copy link
Member

gnprice commented Mar 20, 2024

@sm-sayedi Thanks! Please go ahead.

That demo looks good, except that I'd put less vertical spacing between the items in the results. If you can find an example of this UI in @terpimost's Figma design for mobile, though, then follow what that says. @terpimost might also add a comment in this thread.

(As usual, please prioritize revisions on existing PRs over starting new ones — so that means revising #560 based on the feedback in the review I just left there. But once that's all ready for another review, this would be a good next issue.)

sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 25, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 25, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 25, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 26, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants