-
Notifications
You must be signed in to change notification settings - Fork 309
Remove notifications when messages are read, on Android #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Mentioned in feedback here: (Which was the first day after Android notifications started working generally.) |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I picked this up today, and I've gotten the feature working successfully in a draft branch. There's still a fair amount of cleanup needed to turn that into something mergeable, though. The way this feature works in zulip-mobile (which has worked quite well) is that on each notification we include in the "extras" a key To date, the way we've been interacting with the Android SDK for controlling notifications is with
I decided this was a good prompt for trying out Pigeon and doing #351. It worked. Pigeon has some rough edges, but it definitely feels a lot more pleasant than trying to write by hand all the serialization, deserialization, and dispatch logic for talking between Dart and Kotlin. My current draft branch doesn't do all of #351, in that it doesn't replace some of the other methods which aren't involved in this feature. But it already replaces by far the most complex of those methods, for showing a notification (so that we can set that value in "extras" in the first place). So I might just do #351 completely along the way to this issue. |
Parts of that draft branch turned into #592, toward #351 switching to Pigeon. I've now taken the remainder of that draft branch, rebased it atop all the other changes that have happened in our notifications code, and sent it as a draft PR #864. So @rajveermalviya with that branch you now have all the work I've done toward this issue, and you can go from there without duplicating work. |
Fixes zulip#341 Co-authored-by: Greg Price <[email protected]>
Fixes: zulip#341 Co-authored-by: Greg Price <[email protected]>
Fixes: zulip#341 Co-authored-by: Greg Price <[email protected]>
Fixes: zulip#341 Co-authored-by: Greg Price <[email protected]>
Fixes: zulip#341 Co-authored-by: Greg Price <[email protected]>
Fixes: zulip#341 Co-authored-by: Greg Price <[email protected]>
This change is similar to existing implementation in zulip-mobile: https://github.com/zulip/zulip-mobile/blob/2217c858e207f9f092651dd853051843c3f04422/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L116-L168 Fixes: zulip#341 Co-authored-by: Greg Price <[email protected]>
This change is similar to existing implementation in zulip-mobile: https://github.com/zulip/zulip-mobile/blob/2217c858e207f9f092651dd853051843c3f04422/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L116-L168 Fixes: zulip#341 Co-authored-by: Greg Price <[email protected]>
This change is similar to existing implementation in zulip-mobile: https://github.com/zulip/zulip-mobile/blob/2217c858e207f9f092651dd853051843c3f04422/android/app/src/main/java/com/zulipmobile/notifications/NotificationUiManager.kt#L116-L168 Fixes: zulip#341 Co-authored-by: Greg Price <[email protected]>
We have this feature in zulip-mobile, and should match it here.
We should also eventually add this feature on iOS. We don't yet have it there in zulip-mobile (zulip/zulip-mobile#3119), so that will be tracked separately and happen later.
The text was updated successfully, but these errors were encountered: