Skip to content

Handle <hr> horizontal lines #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #309
gnprice opened this issue Nov 1, 2023 · 4 comments · Fixed by #603
Closed
Tracked by #309

Handle <hr> horizontal lines #353

gnprice opened this issue Nov 1, 2023 · 4 comments · Fixed by #603
Assignees
@Khader-1
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents beta feedback Things beta users have specifically asked for
Milestone
M2: Beta 2, Sprin...

Comments

@gnprice
Copy link
Member

gnprice commented Nov 1, 2023

We should handle the <hr> element.

This element means a "thematic break", shown as a dividing line; the name stands for "horizontal rule". It's the result of a --- line in Markdown.

Handling these means parsing them in lib/model/content.dart, and then styling them appropriately in lib/widgets/content.dart. For appropriate styling, see the Zulip web app's web/styles/rendered_markdown.css.
@gnprice gnprice added the a-content Parsing and rendering Zulip HTML content, notably message contents label Nov 1, 2023
@gnprice gnprice added this to the Beta milestone Nov 1, 2023
@gnprice gnprice mentioned this issue Nov 1, 2023
Closed
9 tasks
@gnprice gnprice modified the milestones: Beta 1, Beta 2 Nov 8, 2023
@gnprice gnprice modified the milestones: Beta 2, Beta 3 Nov 22, 2023
@jassirr

This comment was marked as off-topic.

Sign in to view
@jassirr

This comment was marked as off-topic.

Sign in to view
@Khader-1
Copy link
Collaborator

Khader-1 commented Mar 25, 2024 •
edited
Loading

Instructive, but I imagine having the link to web/styles/rendered_markdown.css would give more context for readers.
Anyways, I am working on it!

Current progress:
Simulator Screenshot - iPhone 15 Pro Max - 2024-03-25 at 10 32 14

Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Mar 29, 2024
@Khader-1
content: Handle <hr> horizontal lines
5a9ba2b 
Fixes: zulip#353
@Khader-1 Khader-1 mentioned this issue Mar 29, 2024
Merged
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Mar 29, 2024
@Khader-1
content: Handle <hr> horizontal lines
f6f3503 
Fixes: zulip#353
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Mar 30, 2024
@Khader-1
content: Handle <hr> horizontal lines
ec95eb3 
Fixes: zulip#353
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Apr 2, 2024
@Khader-1
content: Handle <hr> horizontal lines
d5e07e6 
Fixes: zulip#353
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Apr 2, 2024
@Khader-1
content: Handle <hr> horizontal lines
36391f8 
Fixes: zulip#353
@gnprice gnprice added the beta feedback Things beta users have specifically asked for label Apr 3, 2024
@gnprice
Copy link
Member Author

gnprice commented Apr 3, 2024

Seen by a beta user: chat thread.

@gnprice gnprice modified the milestones: Beta 3, Beta 2 Apr 3, 2024
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Apr 4, 2024
@Khader-1
content: Handle <hr> horizontal lines
736cd84 
Fixes: zulip#353
@gnprice gnprice closed this as completed in a7d97d5 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Khader-1 Khader-1

Labels
a-content Parsing and rendering Zulip HTML content, notably message contents beta feedback Things beta users have specifically asked for
Projects
Flutter app
Status: Done
Milestone
M2: Beta 2, Spring 2024
Development

Successfully merging a pull request may close this issue.

content: Handle <hr> horizontal lines Khader-1/zulip-flutter
3 participants
@gnprice @Khader-1 @jassirr