Skip to content

Handle <time> elements ("global times") #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #309
gnprice opened this issue Nov 1, 2023 · 0 comments · Fixed by #504
Closed
Tracked by #309

Handle <time> elements ("global times") #354

gnprice opened this issue Nov 1, 2023 · 0 comments · Fixed by #504
Assignees
@sirpengi
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Milestone
M2: Beta 2, Sprin...

Comments

@gnprice
Copy link
Member

gnprice commented Nov 1, 2023

We should handle <time> elements. These are the output of the Zulip "global times" feature: https://zulip.com/help/global-times

Handling these means parsing them in lib/model/content.dart, and then styling them appropriately in lib/widgets/content.dart. For appropriate styling, see the Zulip web app's web/styles/rendered_markdown.css.
@gnprice gnprice added the a-content Parsing and rendering Zulip HTML content, notably message contents label Nov 1, 2023
@gnprice gnprice added this to the Beta milestone Nov 1, 2023
@gnprice gnprice mentioned this issue Nov 1, 2023
Closed
9 tasks
@gnprice gnprice modified the milestones: Beta 1, Beta 2 Nov 8, 2023
@sirpengi sirpengi self-assigned this Jan 24, 2024
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Jan 31, 2024
@sirpengi
content: Implement GlobalTime
4a424dd 
Fixes: zulip#354
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Feb 2, 2024
@sirpengi
content: Implement GlobalTime
b3933e8 
Fixes: zulip#354
@sirpengi sirpengi mentioned this issue Feb 5, 2024
Merged
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Feb 6, 2024
@sirpengi
content: Implement GlobalTime
a952098 
Fixes: zulip#354
@gnprice gnprice closed this as completed in e1bff3e Feb 7, 2024
@chrisbobbe chrisbobbe mentioned this issue Dec 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirpengi sirpengi

Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Projects
Flutter app
Status: Done
Milestone
M2: Beta 2, Spring 2024
Development

Successfully merging a pull request may close this issue.

Global Times sirpengi/zulip-flutter
2 participants
@gnprice @sirpengi