Skip to content

Handle spoiler blocks #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #309
gnprice opened this issue Nov 1, 2023 · 0 comments · Fixed by #503
Closed
Tracked by #309

Handle spoiler blocks #358

gnprice opened this issue Nov 1, 2023 · 0 comments · Fixed by #503
Assignees
@chrisbobbe
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Milestone
M2: Beta 2, Sprin...

Comments

@gnprice
Copy link
Member

gnprice commented Nov 1, 2023

We should handle "spoiler" blocks in message content, i.e. this Zulip feature: https://zulip.com/help/spoilers

Handling these means parsing them in lib/model/content.dart, and then displaying them appropriately in lib/widgets/content.dart. For appropriate styling, see the Zulip web app's web/styles/rendered_markdown.css.
@gnprice gnprice added the a-content Parsing and rendering Zulip HTML content, notably message contents label Nov 1, 2023
@gnprice gnprice added this to the Beta milestone Nov 1, 2023
@gnprice gnprice mentioned this issue Nov 1, 2023
Closed
9 tasks
@gnprice gnprice modified the milestones: Beta 1, Beta 2 Nov 8, 2023
@chrisbobbe chrisbobbe self-assigned this Jan 24, 2024
@chrisbobbe chrisbobbe mentioned this issue Feb 15, 2024
Merged
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Feb 24, 2024
@chrisbobbe
content: Handle spoilers
8bad174 
Fixes: zulip#358
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Feb 24, 2024
@chrisbobbe
content: Handle spoilers
62fffc5 
Fixes: zulip#358
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Feb 26, 2024
@chrisbobbe
content: Handle spoilers
17c8ccc 
Fixes: zulip#358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Projects
Flutter app
Status: Done
Milestone
M2: Beta 2, Spring 2024
Development

Successfully merging a pull request may close this issue.

content: Support spoilers! chrisbobbe/zulip-flutter
2 participants
@gnprice @chrisbobbe