-
Notifications
You must be signed in to change notification settings - Fork 310
Set the HTTP user agent #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The value should probably say "ZulipMobile" somewhere, because apparently (#453 (comment)) for send-message requests that will activate the server's heuristic for deciding we're a UI client and therefore the newly sent message should be marked as read for its author, solving #440. For some discussion on how to implement this, see #453. |
But this should be marked with a |
Currently when we make an HTTP request, the
User-Agent
header we send is just whatever the default is that Dart's HTTP implementation gives us. This means e.g. that log lines on the server look like this, saying "via Dart":Instead we should set a user-agent string that identifies this app. Ideally it should include the app's version number.
There are at least two different kinds of HTTP requests the app makes, both of which should have the user agent set:
ApiConnection.send
;RealmContentNetworkImage
.It's likely those will need to be handled separately.
The text was updated successfully, but these errors were encountered: