ui: Consistently use "Noto Color Emoji" for emojis on Android (i.e., always include it as a fallback font) #438
Labels
Milestone
Comments
chrisbobbe
added
the
a-Android
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Dec 6, 2023
In zulip#436, we brought back Noto Color Emoji, but just for reaction chips. This brings it to message content in the message list, and all the other places where we've been specifying Source Sans 3. This leaves some edge cases where we'll still fall back to a system emoji font, like if there's an emoji in a user's name and you're looking at the profile screen. (Or in the "sender" area of a message in the message list, for that matter, checking again just now.) Those will be fixed later in this series, along with a cleanup that eliminates the repetition of [kDefaultFontFamily] and [kDefaultFontFamilyFallback] that we see in this commit. Fixes-partly: zulip#438
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Dec 6, 2023
…styles With plumbing to make kDefaultFamily work, since it's a variable-weight font. As it happens, most -- perhaps all -- of the app's text is built on Typography styles. See the next commit for some thoughts on that. Since that's the case, I'll mark this commit as fixing these issues: - zulip#294 "Use "Source Sans 3" font for most UI text" - zulip#438 "Consistently use "Noto Color Emoji" for emojis on Android". If there's some corner of the app where the two fonts aren't getting applied, we'll eventually find it, and apply kDefaultFontFamily and kDefaultFontFamilyFallback according to their doc comments, to fix. Fixes: zulip#294 Fixes: zulip#438
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Jan 5, 2024
In zulip#436, we brought back Noto Color Emoji, but just for reaction chips. This brings it to message content in the message list, and all the other places where we've been specifying Source Sans 3. This leaves some edge cases where we'll still fall back to a system emoji font, like if there's an emoji in a user's name and you're looking at the profile screen. (Or in the "sender" area of a message in the message list, for that matter, checking again just now.) Those will be fixed later in this series, along with a cleanup that eliminates the repetition of [kDefaultFontFamily] and [kDefaultFontFamilyFallback] that we see in this commit. Fixes-partly: zulip#438
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Jan 5, 2024
…styles With plumbing to make kDefaultFamily work, since it's a variable-weight font. As it happens, most -- perhaps all -- of the app's text is built on Typography styles. See the next commit for some thoughts on that. Since that's the case, I'll mark this commit as fixing these issues: - zulip#294 "Use "Source Sans 3" font for most UI text" - zulip#438 "Consistently use "Noto Color Emoji" for emojis on Android". If there's some corner of the app where the two fonts aren't getting applied, we'll eventually find it, and apply kDefaultFontFamily and kDefaultFontFamilyFallback according to their doc comments, to fix. Fixes: zulip#294 Fixes: zulip#438
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Jan 5, 2024
In zulip#436, we brought back Noto Color Emoji, but just for reaction chips. This brings it to message content in the message list, and all the other places where we've been specifying Source Sans 3. This leaves some edge cases where we'll still fall back to a system emoji font, like if there's an emoji in a user's name and you're looking at the profile screen. (Or in the "sender" area of a message in the message list, for that matter, checking again just now.) Those will be fixed later in this series, along with a cleanup that eliminates the repetition of [kDefaultFontFamily] and [kDefaultFontFamilyFallback] that we see in this commit. Fixes-partly: zulip#438
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Jan 5, 2024
With plumbing to make kDefaultFamily work, since it's a variable-weight font. As it happens, most -- perhaps all -- of the app's text is built on Typography styles. See the next commit for some thoughts on that. Since that's the case, I'll mark this commit as fixing these issues: - zulip#294 Use "Source Sans 3" font for most UI text - zulip#438 Consistently use "Noto Color Emoji" for emojis on Android If there's some corner of the app where the two fonts aren't getting applied, we'll eventually find it, and apply kDefaultFontFamily and kDefaultFontFamilyFallback according to their doc comments, to fix. Fixes: zulip#294 Fixes: zulip#438
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Jan 9, 2024
In zulip#436, we brought back Noto Color Emoji, but just for reaction chips. This brings it to message content in the message list, and all the other places where we've been specifying Source Sans 3. This leaves some edge cases where we'll still fall back to a system emoji font, like if there's an emoji in a user's name and you're looking at the profile screen. (Or in the "sender" area of a message in the message list, for that matter, checking again just now.) Those will be fixed later in this series, along with a cleanup that eliminates the repetition of [kDefaultFontFamily] and [kDefaultFontFamilyFallback] that we see in this commit. Fixes-partly: zulip#438
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Jan 9, 2024
With plumbing to make kDefaultFamily work, since it's a variable-weight font. As it happens, most -- perhaps all -- of the app's text is built on Typography styles. See the next commit for some thoughts on that. Since that's the case, I'll mark this commit as fixing these issues: - zulip#294 Use "Source Sans 3" font for most UI text - zulip#438 Consistently use "Noto Color Emoji" for emojis on Android If there's some corner of the app where the two fonts aren't getting applied, we'll eventually find it, and apply kDefaultFontFamily and kDefaultFontFamilyFallback according to their doc comments, to fix. Fixes: zulip#294 Fixes: zulip#438
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Feb 2, 2024
In zulip#436, we brought back Noto Color Emoji, but just for reaction chips. This brings it to message content in the message list, and all the other places where we've been specifying Source Sans 3. This leaves some edge cases where we'll still fall back to a system emoji font, like if there's an emoji in a user's name and you're looking at the profile screen. (Or in the "sender" area of a message in the message list, for that matter, checking again just now.) Those will be fixed later in this series, along with a cleanup that eliminates the repetition of [kDefaultFontFamily] and [kDefaultFontFamilyFallback] that we see in this commit. Fixes-partly: zulip#438
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Feb 2, 2024
With plumbing to make kDefaultFamily work, since it's a variable-weight font. As it happens, most -- perhaps all -- of the app's text is built on Typography styles. See the next commit for some thoughts on that. Since that's the case, I'll mark this commit as fixing these issues: - zulip#294 Use "Source Sans 3" font for most UI text - zulip#438 Consistently use "Noto Color Emoji" for emojis on Android If there's some corner of the app where the two fonts aren't getting applied, we'll eventually find it, and apply defaultFontFamily and defaultFontFamilyFallback according to their doc comments, to fix. Fixes: zulip#294 Fixes: zulip#438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #436, we brought back Noto Color Emoji, but just for reaction chips. We should use it everywhere else that emojis can appear.
The text was updated successfully, but these errors were encountered: