Skip to content

Update unreads data on fetching messages #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnprice opened this issue May 8, 2024 · 0 comments
Open

Update unreads data on fetching messages #649

gnprice opened this issue May 8, 2024 · 0 comments
Labels
a-model Implementing our data model (PerAccountStore, etc.)

Comments

@gnprice
Copy link
Member

gnprice commented May 8, 2024

When a new message comes in, we update the Unreads data structure, store.unreads. But when we go and fetch a bunch of messages for a message list, we don't.

Mostly this works out, because the initial snapshot has an unreads digest that already covers the most recent unreads, up to a large number of them. But if you go look at some very old history where you have unreads, we'll end up with messages we know are unread but store.unreads doesn't reflect it. This is odd and would be good to fix.

This will most naturally come after a central message store, #648 / #455.

Milestoned post-launch because we don't currently do this in zulip-mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-model Implementing our data model (PerAccountStore, etc.)
Projects
Status: No status
Development

No branches or pull requests

1 participant