-
Notifications
You must be signed in to change notification settings - Fork 310
Rename "All messages" to "Combined feed" in our codebase #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
Lalit3716
added a commit
to Lalit3716/zulip-flutter
that referenced
this issue
May 19, 2024
Lalit3716
added a commit
to Lalit3716/zulip-flutter
that referenced
this issue
May 19, 2024
Lalit3716
added a commit
to Lalit3716/zulip-flutter
that referenced
this issue
May 21, 2024
Lalit3716
added a commit
to Lalit3716/zulip-flutter
that referenced
this issue
May 21, 2024
Lalit3716
added a commit
to Lalit3716/zulip-flutter
that referenced
this issue
May 23, 2024
Lalit3716
added a commit
to Lalit3716/zulip-flutter
that referenced
this issue
May 23, 2024
Lalit3716
added a commit
to Lalit3716/zulip-flutter
that referenced
this issue
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a followup to:
That issue was for updating the UI. We should also update all the references to this Zulip feature within our code.
A good search to use for this is:
git grep -iP 'all.?messages'
That will find the phrase "all messages" with any capitalization, and with or without a space (or other character) in between the words. Currently it finds 73 results.
When this issue is complete, that search's results won't necessarily be empty — there may be a few matches that aren't referring to the former "All messages" narrow, now called "Combined feed". But it should be possible to look at each of the remaining results and determine how that's not what it's referring to.
For this issue, the most important part of the work is making a highly reviewable PR. Be sure to review that page of the Zulip docs, and the page on clear and coherent commits.
The text was updated successfully, but these errors were encountered: