Skip to content

content: Bold spans aren't bolder than surrounding text in spoiler headers or h1/h2/etc. #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisbobbe opened this issue May 24, 2024 · 1 comment · Fixed by #706
Closed

content: Bold spans aren't bolder than surrounding text in spoiler headers or h1/h2/etc. #705

chrisbobbe opened this issue May 24, 2024 · 1 comment · Fixed by #706
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents

Comments

@chrisbobbe
Copy link
Collaborator

Bold spans should be bolder than surrounding text, even when that surrounding text is bold because it's in a spoiler header or an h1/h2/etc. (or column headings in tables, with #360).

Current Better
75927CB2-41BB-415B-9530-CE418DBB9368 445F7D01-3E38-4A19-B5CD-7746474655D5

In fact, in the spoiler header, the bold text is less bold. That's because, following web, we hard-code bold spans to weight 600 but spoiler headers to weight 700.
@chrisbobbe chrisbobbe added the a-content Parsing and rendering Zulip HTML content, notably message contents label May 24, 2024
@chrisbobbe
Copy link
Collaborator Author

In fact, web also fails with this. Here are the same messages screenshotted on web:

image

chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 24, 2024
@chrisbobbe
content: Make **bold** bolder even in spoiler headers and h1/h2/etc.
bd3630d 
Fixes: zulip#705
@chrisbobbe chrisbobbe mentioned this issue May 24, 2024
Merged
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 31, 2024
@chrisbobbe
content: Make **bold** bolder even in spoiler headers and h1/h2/etc.
61754f7 
Fixes: zulip#705
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 31, 2024
@chrisbobbe
content: Make **bold** bolder even in spoiler headers and h1/h2/etc.
ce28fbb 
Fixes: zulip#705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Projects
Flutter app
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

content: Make **bold** bolder even in spoiler headers and h1/h2/etc. chrisbobbe/zulip-flutter
1 participant
@chrisbobbe