content: Update code-block syntax highlighting styles for light mode #754
Labels
a-content
Parsing and rendering Zulip HTML content, notably message contents
Milestone
Comments
chrisbobbe
added
the
a-content
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Jun 20, 2024
The dark-theme styles, which we'll add soon, have something for all of `CodeBlockSpanType`'s values. While we're at it, write the TODO(zulip#754) to update the light-theme styles. (Hopefully to something that also has a style for all of `CodeBlockSpanType`'s values.)
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Jun 22, 2024
This referred to the dark theme that web was using before it switched to Pygments Monokai, in zulip/zulip#26898. No particular need to explain the choice of background color, especially as we intend to replace these styles anyway; that's zulip#754.
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Jun 26, 2024
The dark-theme styles, which we'll add soon, have something for all of `CodeBlockSpanType`'s values. While we're at it, write the TODO(zulip#754) to update the light-theme styles. (Hopefully to something that also has a style for all of `CodeBlockSpanType`'s values.)
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Jun 26, 2024
The dark-theme styles, which we'll add soon, have something for all of `CodeBlockSpanType`'s values. While we're at it, write the TODO(zulip#754) to update the light-theme styles. (Hopefully to something that also has a style for all of `CodeBlockSpanType`'s values.)
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Jul 5, 2024
On hot-reload, `lerp` is triggered even when the theme has not changed. Discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Exceptions.20during.20hot.20reloads/near/1846095 I considered just going ahead with placing the web app's current light-theme styles for code blocks (zulip#754), but pretty soon I realized there would still be some nulls in there after doing so, and those would need to be treated like we're treating the nulls here.
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Jul 5, 2024
On hot-reload, `lerp` is triggered even when the theme has not changed. Discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Exceptions.20during.20hot.20reloads/near/1846095 I considered just going ahead with placing the web app's current light-theme styles for code blocks (zulip#754), but pretty soon I realized there would still be some nulls in there after doing so, and those would need to be treated like we're treating the nulls here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In 2023-12, web changed the set of colors it uses for syntax highlighting in code blocks in light mode. That was after we first implemented light-mode syntax highlighting here, so we're out of sync with web.
However, as Greg points out in #689 (comment) , the discussion on web's change petered out with some open feedback, and no firm conclusion on what we'd do next.
So, let's first await a color scheme in web that's reasonably stable/happy, then translate it to zulip-flutter.
The text was updated successfully, but these errors were encountered: