Skip to content

Use new null-safe generics in Pigeon #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnprice opened this issue Sep 13, 2024 · 4 comments · Fixed by #1278
Closed

Use new null-safe generics in Pigeon #942

gnprice opened this issue Sep 13, 2024 · 4 comments · Fixed by #1278

Comments

@gnprice
Copy link
Member

gnprice commented Sep 13, 2024

The Pigeon feature request to handle types like List<Foo>, as opposed to only List<Foo?>, is complete:

We have a couple of types in our pigeon/notifications.dart that could benefit from that. One has a TODO comment; for the full list, look for List< and Map<.

@ArpanMondalGITHUB
Copy link

Can I work on it

@skylon07

This comment was marked as off-topic.

@gnprice

This comment was marked as off-topic.

@skylon07

This comment was marked as off-topic.

@PIG208 PIG208 added this to the Post-launch milestone Oct 1, 2024
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jan 13, 2025
Fixes: zulip#942

And migrate to using non-nullable generic types.

Changelog:
  https://pub.dev/packages/pigeon/changelog#2272
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jan 16, 2025
Fixes: zulip#942

And migrate to using non-nullable generic types.

Changelog:
  https://pub.dev/packages/pigeon/changelog#2272
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jan 19, 2025
Now that we use the version of Pigeon package that supports
non-nullable types in collections, update our Pigeon files
to incorporate them.

Fixes: zulip#942
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jan 21, 2025
Now that we use the version of Pigeon package that supports
non-nullable types in collections, update our Pigeon files
to incorporate them.

Fixes: zulip#942
E-m-i-n-e-n-c-e pushed a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Jan 23, 2025
Now that we use the version of Pigeon package that supports
non-nullable types in collections, update our Pigeon files
to incorporate them.

Fixes: zulip#942
rishichirchi pushed a commit to rishichirchi/zulip-flutter that referenced this issue Feb 7, 2025
Now that we use the version of Pigeon package that supports
non-nullable types in collections, update our Pigeon files
to incorporate them.

Fixes: zulip#942
github-actions bot pushed a commit that referenced this issue Feb 12, 2025
Now that we use the version of Pigeon package that supports
non-nullable types in collections, update our Pigeon files
to incorporate them.

Fixes: #942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants