Unify httpStatus field on ApiRequestException subclasses #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! There's a conflict but I think it's just an indentation thing; please merge at will after resolving that. |
chrisbobbe
added
the
integration review
chrisbobbe
removed
the
maintainer review
We're about to group the others together under a new sibling of this class, so it'll be cleanest if this one doesn't appear in the midst of the others.
This expresses more directly what we really mean here: if the response had either the HTTP status code or the Zulip API error code that mean a rate-limit error, treat it as a rate-limit error.
gnprice
force-pushed
the
pr-http-exception
branch
from
2eea635 to
531af69
Compare
|
Thanks! Done. Yeah, #1187 moved some of the same code this edits, and made it a few levels less deeply indented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #1187, this is a follow-up to #1063. It's a thought I had while working on those changes, but didn't pursue then because the PR was long and complex enough already.
Commit messages
ab291ad api [nfc]: Reorder NetworkException to before sibling classes
We're about to group the others together under a new sibling of
this class, so it'll be cleanest if this one doesn't appear in the
midst of the others.
bdd625d api [nfc]: Add HttpException as base-class home for httpStatus field
2eea635 store [nfc]: Use HttpException to simplify error cases
This expresses more directly what we really mean here: if the
response had either the HTTP status code or the Zulip API error code
that mean a rate-limit error, treat it as a rate-limit error.