theme [nfc]: Make DesignVariables.{light,dark} final fields, not constructors #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(nit: the status quo is they're constructors, not methods) |
chrisbobbe
changed the title
|
Indeed :) thanks for the catch |
chrisbobbe
force-pushed
the
pr-design-variables-final-fields
branch
from
aeb0f73 to
8cb19bb
Compare
PIG208
added
integration review
|
LGTM! We should be able to apply this to |
Instead of constructors. Nicer to compute each of these just once.
gnprice
force-pushed
the
pr-design-variables-final-fields
branch
from
8cb19bb to
dcc8123
Compare
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nicer to compute each of these just once.