Skip to content

api: Get and send messages from arbitrary places, not hard-coded #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 31, 2023

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented May 31, 2023

(Stacked atop #137.)

This PR extends the API bindings for getMessages and sendMessage so that they cover the API more completely. In particular this means:

  • getMessages accepts a general narrow, rather than hardcoding the all-messages narrow.
  • sendMessage accepts an arbitrary conversation, rather than only stream conversations and hardcoded to #test here (and limited to chat.zulip.org).

This takes us toward:

Still to do for that issue, and present in a draft branch:

  • adding streams data from the server
  • adapting the compose box by narrow
  • adapting the message-list app bar by narrow
  • making recipient headers touchable to navigate to different narrows
  • adding PmNarrow as another Narrow subclass

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented May 31, 2023

This LGTM after #137 is in; please see #137 (comment).

@gnprice gnprice merged commit ddbb34d into zulip:main May 31, 2023
@gnprice gnprice deleted the pr-narrow-api branch May 31, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants