Support saved snippets #1391
Open
Support saved snippets #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIG208
force-pushed
the
pr-saved
branch
4 times, most recently
from
118311e to
18dae84
Compare
PIG208
force-pushed
the
pr-saved
branch
5 times, most recently
from
2989a73 to
6647a7f
Compare
PIG208
force-pushed
the
pr-saved
branch
2 times, most recently
from
e365852 to
e816364
Compare
|
This has a failing test, could you take a look please? |
The theme already applies to all of our bottom sheets, and all of them uses Clip.antiAlias already. Signed-off-by: Zixuan James Li <[email protected]>
The icons taken are from the Figma design: plus: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4912-31325&m=dev message-square-text: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=7965-53132&m=dev Signed-off-by: Zixuan James Li <[email protected]>
Not all buttons are about uploading files, while most of the buttons on the compose box share the same design. Extract that part for later use. Signed-off-by: Zixuan James Li <[email protected]>
This will disable autocomplete on the input, since narrow is required for MentionAutocomplete… classes to function. In the future, a better solution can make these autocomplete classes support null narrow, by perhaps disabling wildcard mentions autocomplete, while still allowing other types of autocompletion that make sense in a saved snippet's compose box.
We sort the saved snippets by title to be consistent with the web implementation. A subtle nuance of having a compose box in a modal bottom sheet is that the message list page behind will shift when the keyboard is expanded, even though its compose box is not visible anyway. An UX improvement would be preserving the inputs on the saved snippet compose box after the user has navigated away. Fixes: zulip#863
|
Oh right. Thanks! Pushed an update. I realized that I didn't make this clear — let's get #1511 reviewed first, since that's the prerequisite of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CZO discussion
Stacked on top of #1498.
screenshots
Fixes: #863