Skip to content

Distinguish muted users in UI #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Distinguish muted users in UI #1429

wants to merge 11 commits into from

Conversation

sm-sayedi
Copy link
Collaborator

Note: No tests are included in this draft revision.

This PR aims to respect the user's settings for muting other users by distinguishing its related UI appearance. From the list of places in UI mentioned in https://zulip.com/help/mute-a-user, the following are included as they're compatible with the current scope of mobile:

  • Combined feed sent by muted users, including the name, profile picture, and message content, are hidden behind a Click here to reveal banner. A revealed message can later be re-hidden.
Message from muted user (Before) Message from muted user (After)
Revealed muted message Revealed muted message (Long-pressed)
  • Muted users have their name displayed as "Muted user" for emoji reactions, polls, and when displaying the recipients of group direct messages.
Emoji reactions | Poll (Before) Emoji reactions | Poll (After)
Group DMs with muted user (Before) Group DMs with muted user (After)
Recent DMs view (Before) Recent DMs view (After)
  • Recent conversations and other features that display avatars will show a generic user symbol in place of a muted user's profile picture.
Custom profile field (Before) Custom profile field (After)
  • Muted users are excluded from the autocomplete for composing a direct message or mentioning a user.

Fixes: #296

@sm-sayedi sm-sayedi force-pushed the 296-respect-muted-users branch from c34b94b to d80442b Compare March 24, 2025 03:49
@sm-sayedi sm-sayedi force-pushed the 296-respect-muted-users branch 3 times, most recently from 86d0e66 to db3216f Compare May 2, 2025 19:01
@sm-sayedi sm-sayedi force-pushed the 296-respect-muted-users branch from db3216f to 17f2f6b Compare May 6, 2025 02:06
sm-sayedi added 11 commits May 17, 2025 07:12
@sm-sayedi
api: Add InitialSnapshot.mutedUsers
56fdb09
@sm-sayedi
user: Add UserStore.isUserMuted
7b40a29
@sm-sayedi
api: Handle muted_users event
d682a0f
@sm-sayedi
icons: Add "person", "eye", and "eye_off" icons
ed38fca 
Also renamed "user" to "two_person" to make it consistent with other
icons of the same purpose.

New icons taken from:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=5968-237884&t=dku3J5Fv2dmWo7ht-0

  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=5968-264632&t=dku3J5Fv2dmWo7ht-0

  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=5968-291260&t=B5jAmeUMMG4dlsU7-0
@sm-sayedi
msglist: Distinguish messages sent by muted senders
854081e 
Figma design:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=6089-28385&t=28DdYiTs6fXWR9ua-0

Fixes: zulip#296
@sm-sayedi
msglist/emoji: Distinguish muted users in message list page and react…
f84bd53 
…ions
@sm-sayedi
poll: Distinguish muted users in polls
a64c705
@sm-sayedi
recent-dms: Distinguish muted users in recent DMs page
e5087ad
@sm-sayedi
recent-dms: Exclude DM conversations with muted users
ae0462f
@sm-sayedi
profile: Distinguish muted users in custom profile fields of type User
2d1d1c4
@sm-sayedi
autocomplete: Exclude muted users from user-mention autocomplete
46c6536
@sm-sayedi sm-sayedi force-pushed the 296-respect-muted-users branch from 17f2f6b to 46c6536 Compare May 18, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mute muted users
1 participant
@sm-sayedi