-
Notifications
You must be signed in to change notification settings - Fork 309
KaTeX (2/n): Support horizontal and vertical offsets for spans #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rajveermalviya
wants to merge
14
commits into
zulip:main
Choose a base branch
from
rajveermalviya:pr-tex-content-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,003
−119
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2732beb
content test [nfc]: Use const for math block tests
rajveermalviya 860dd00
content [nfc]: Inline _logError in _KatexParser._parseSpan
rajveermalviya 0a47cc5
content [nfc]: Refactor _KatexParser._parseChildSpans to take list of…
rajveermalviya 4c62181
content: Scale inline KaTeX content based on the surrounding text
rajveermalviya 8e12ca9
content: Support parsing and handling inline styles for KaTeX content
rajveermalviya c439396
content [nfc]: Reintroduce KatexNode as a base sealed class
rajveermalviya 726621a
content: Ignore more KaTeX classes that don't have CSS definition
rajveermalviya 284464d
content: Handle 'mspace' and 'msupsub' KaTeX CSS classes
rajveermalviya ee9d42c
content: Handle positive margin-right and margin-left in KaTeX spans
rajveermalviya 002b338
content: Handle 'top' property in KaTeX span inline style
rajveermalviya 7588b96
content [nfc]: Remove the `inline` property in _Katex widget
rajveermalviya d01d5d4
deps: Add file as a direct dependency
rajveermalviya ec14306
content: Handle vertical offset spans in KaTeX content
rajveermalviya c917d14
content [test]: Add golden tests for KaTeX content
rajveermalviya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One point that I noticed while developing #1478 (and checking how my draft of that branch interacted with this PR): it'd be good for this commit:
e268041 content: Handle vertical offset spans in KaTeX content
to get split up like so:
One reason that'd be useful is that the split between KatexNode and KatexSpanNode is somewhat nontrivial in itself: some of the references to KatexNode continue to say KatexNode, while others switch to saying KatexSpanNode, so the commit is expressing meaningful information by its choices of which references go which way.