Skip to content

store [nfc]: Add PerAccountStoreBase to provide connection to substores #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

chrisbobbe
Copy link
Collaborator

And demonstrate its use, with MessageStoreImpl.

This will be a convenient way to provide other common things to substores without needing boilerplate on each substore for each thing.

Co-authored-by: Greg Price [email protected]

…ores

And demonstrate its use, with MessageStoreImpl.

This will be a convenient way to provide other common things to
substores without needing boilerplate on each substore for each
thing.

Co-authored-by: Greg Price <[email protected]>
@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Apr 4, 2025
@chrisbobbe chrisbobbe requested a review from gnprice April 4, 2025 08:06
@gnprice
Copy link
Member

gnprice commented Apr 4, 2025

Thanks! Looks good; merging.

@gnprice gnprice merged commit 31c7511 into zulip:main Apr 4, 2025
1 check passed
@chrisbobbe chrisbobbe deleted the pr-per-account-store-base branch April 5, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants