Skip to content

deps: Upgrade all; fix warning from json_serializable #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Jun 5, 2023

deps: Upgrade Flutter to latest main, 3.11.0-18.0.pre.81

And update Flutter's supporting libraries to match,
namely matcher, test, test_api, and test_core.


deps: Upgrade packages within constraints (flutter pub upgrade)

There are currently no upgrades that --major-versions would add
beyond these.


deps: Bump json_annotation lower bound to latest, 4.8.1

Otherwise we get the following warning when running build_runner
(wrapped here for readability):

[WARNING] json_serializable on lib/api/route/users.dart:
The version constraint "^4.8.0" on json_annotation
allows versions before 4.8.1 which is not allowed.

I believe that warning was introduced with the json_serializable
upgrade from 6.6.2 to 6.7.0 in f28dd0b / #137.

gnprice added 3 commits June 5, 2023 13:00
And update Flutter's supporting libraries to match,
namely matcher, test, test_api, and test_core.
There are currently no upgrades that `--major-versions` would add
beyond these.
Otherwise we get the following warning when running build_runner
(wrapped here for readability):

    [WARNING] json_serializable on lib/api/route/users.dart:
    The version constraint "^4.8.0" on json_annotation
    allows versions before 4.8.1 which is not allowed.

I believe that warning was introduced with the json_serializable
upgrade from 6.6.2 to 6.7.0 in f28dd0b / zulip#137.
@gnprice gnprice mentioned this pull request Jun 7, 2023
@chrisbobbe
Copy link
Collaborator

Thanks!

In testing on macOS, I've realized that I think there are changes in macos/ to be made along the lines of both commits in #148. Should I make those commits, rebase this PR's three commits atop them, test, and then push here?

@gnprice
Copy link
Member Author

gnprice commented Jun 7, 2023

Ah, good thought, thanks.

Those changes are independent of the ones in this PR, though, right? In particular it doesn't look like these changes affect any native plugin code; for example these don't introduce any changes under ios/, and I did run an iOS build to check that none was needed.

So I think the best thing would be to make those changes as a separate PR.

@chrisbobbe
Copy link
Collaborator

Oh OK, right, that makes sense. I'll go ahead and merge this one, then, and send that other work as a separate PR.

@chrisbobbe chrisbobbe merged commit df939dd into zulip:main Jun 7, 2023
@gnprice gnprice deleted the pr-deps branch June 7, 2023 23:02
@chrisbobbe
Copy link
Collaborator

Sent #158.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants