settings: Upgrade Flutter; migrate to new RadioGroup API #1546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And update Flutter's supporting libraries to match, and take an automatic update to the iOS Info.plist file.
This tests the observable behavior more directly. RadioListTile.checked has been deprecated (zulip#1545), so we'd like this test to stop relying on that implementation detail.
This migration is verified by the tests that we touched in the previous commit; they ensure that the buttons' checked state still updates visibly. Fixes: zulip#1545
This was referenced Jun 3, 2025
rajveermalviya
approved these changes
Jun 4, 2025
rajveermalviya
added
integration review
|
Hmm actually—it looks like the Info.plist thing is a breaking change: flutter/flutter@3d8fa621c From my reading of the commit and the migration guide linked from there, it looks like it wouldn't break our |
This was referenced Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1545