Skip to content

msglist: On tap recipient header, open msglist anchored at message #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

chrisbobbe
Copy link
Collaborator

Fixes: #1621
Related: #252

Adapted from the similar test for tapping the topic:
> 'navigates to TopicNarrow on tapping topic in ChannelNarrow'
@chrisbobbe chrisbobbe added the maintainer review PR ready for review by Zulip maintainers label Jun 26, 2025
Copy link
Member

@rajveermalviya rajveermalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chrisbobbe! LGTM.

@rajveermalviya rajveermalviya added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Jun 30, 2025
@rajveermalviya rajveermalviya requested a review from gnprice June 30, 2025 16:13
@gnprice
Copy link
Member

gnprice commented Jul 1, 2025

Looking at this, I'm realizing I don't want this behavior when coming from the combined feed or a channel feed (two things I regularly do). In my common workflows, I'm catching up by scrolling those near the end; I see there's some conversation that looks relevant for me; I want to see the conversation from the beginning, or the beginning of what I haven't previously read. So first-unread is exactly what I want.

We had a chat thread where this behavior came up in the context of search, right? I'm not finding it at the moment — it looks like #1621 didn't get mentioned there. Let's discuss in that thread what the logic should be for this.

@chrisbobbe
Copy link
Collaborator Author

I don't think there's a chat thread, there's just what I wrote on the issue:

This will be helpful for:

and should be easy to do.

So I've just started one: #mobile-team > msglist: anchor when tapping recipient header @ 💬

@gnprice
Copy link
Member

gnprice commented Jul 2, 2025

Sounds good. I ran across this comment today: #252 (comment) and I think it might have been what I was thinking of.

@chrisbobbe chrisbobbe closed this Jul 2, 2025
@chrisbobbe
Copy link
Collaborator Author

Closing in favor of #1657 (but I've kept the add-a-missing-test commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msglist: When tapping a message in starred/mentions/search, open conversation view at that message
3 participants