android build: Migrate to kotlin.compilerOptions from kotlinOptions
#1829
Conversation
rajveermalviya
force-pushed
the
pr-migrate-kotlinOptions
branch
from
842aceb to
29e9482
Compare
rajveermalviya
added
the
maintainer review
| tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).configureEach { | ||
| kotlin { | ||
| compilerOptions { | ||
| jvmTarget = org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_1_8 | ||
| } | ||
| } | ||
|
|
||
| tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinJvmCompile).configureEach { |
There was a problem hiding this comment.
What's the reason to change org.jetbrains.kotlin.gradle.tasks.KotlinCompile to org.jetbrains.kotlin.gradle.tasks.KotlinJvmCompile?
There was a problem hiding this comment.
KotlinCompile (not sure why it's documentation is in org.jetbrains.kotlin.gradle.dsl package and not org.jetbrains.kotlin.gradle.tasks) is deprecated in favor of one-of the KotlinCompilationTask, and KotlinJvmCompile is a subclass of KotlinCompilationTask.
Also the migration guide (expand the "Migrate from kotlinOptions {} to compilerOptions {}" section) has a handy migration example for this "compilation unit level" configuration.
There was a problem hiding this comment.
(I think you mean KotlinCompile is the deprecated thing?)
chrisbobbe
added
integration review
|
Thanks! LGTM, marking for Greg's review. |
See:
https://kotlinlang.org/docs/gradle-compiler-options.html#migrate-from-kotlinoptions-to-compileroptions
Fixes: #1804