store: Update streams and subscriptions on stream-create/delete events

[chrisbobbe]

Also, add addStream / addStreams helpers to PerAccountStoreTestExtension. We'll use those soon, to write tests for message-link creation for quote-and-reply.

Fixes: #181
Related: #182

[chrisbobbe]

I'm not sure if I've followed the right ordering in the added code—in lib/api/model, I've tried to follow the API doc; in lib/model, I've tried to follow lib/api/model/model.dart.

[gnprice]

Thanks! All LGTM with a suggestion on the ordering.

I'm not sure if I've followed the right ordering in the added code—in lib/api/model, I've tried to follow the API doc; in lib/model, I've tried to follow lib/api/model/model.dart.

Yeah. In lib/api/model/events.dart I originally wanted to follow the ordering in the API doc… until I went to implement the realm_user events. Search the page for "realm_user op:" and you'll see why: realm_user/update events are way up near the top, while realm_user/add and realm_user/remove events come quite a bit later. In between are message, several flavors of subscription, and others.

I definitely wanted the different op values for a given type to be together, so it wasn't going to work to stick to the docs' ordering.

That means that in order to compare the lists for completeness we'll need to do something else anyway. So we might as well put the events in an order that makes sense to us semantically.

Given that, I'd put these event types in events.dart in the same order as you have them in handleEvent. More generally, I'd go for the same broad order as in lib/api/model/model.dart, which is also the one in zulip-mobile's src/api/modelTypes.js:

• first info about the realm as a whole,
• then about users,
• then about streams and subscriptions,
• then about messages.

[chrisbobbe]

Makes sense! Thanks for the review; revision pushed.

[gnprice]

Thanks! Merging.