deps: Upgrade Flutter to work around Flutter version-solving bug #1859
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
the
integration review
CI is broken by what looks like a bug in `flutter pub get`: Resolving dependencies... The current Flutter SDK version is 3.37.0-1.0.pre-175. Because zulip requires Flutter SDK version >=3.37.0-1.0.pre-89, version solving failed. Failed to update packages. It looks like the number at the end is being compared lexicographically, not numerically as it should be. That should be fixed, but for now, work around by just bumping the threshold to a version where that number starts with "1".
|
Thanks for the fix. Pretty silly upstream bug. The fix/workaround looks good; merging. |
gnprice
force-pushed
the
pr-upgrade-flutter-to-fix-ci
branch
from
9832202 to
7cab2ad
Compare
gnprice
added
the
upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is broken by what looks like a bug in
flutter pub get:Resolving dependencies...
The current Flutter SDK version is 3.37.0-1.0.pre-175.
Because zulip requires Flutter SDK version >=3.37.0-1.0.pre-89,
version solving failed.
Failed to update packages.
It looks like the number at the end is being compared lexicographically, not numerically as it should be. That should be fixed, but for now, work around by just bumping the threshold to a version where that number starts with "1".