dev deps: Upgrade checks to 0.3.0, handling breaking changes
#502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
reviewed
Feb 2, 2024
test/api/core_test.dart
Outdated
| ..field.equals('file') | ||
| ..length.equals(length) | ||
| ..filename.equals(filename) | ||
| ..has<Future<List<int>>>((f) => f.finalize().toBytes(), 'contents') | ||
| .completes(it()..deepEquals(content.expand((l) => l))) | ||
| .completes((it) => it..deepEquals(content.expand((l) => l))) |
There was a problem hiding this comment.
nit:
Suggested change
| .completes((it) => it..deepEquals(content.expand((l) => l))) | |
| .completes((it) => it.deepEquals(content.expand((l) => l))) |
Similarly in a few other places — wherever there's just one .. cascading call.
chrisbobbe
force-pushed
the
pr-upgrade-checks
branch
from
92e9478 to
1700bb6
Compare
|
Thanks for the review! Revision pushed, with those tweaks. |
chrisbobbe
force-pushed
the
pr-upgrade-checks
branch
from
1700bb6 to
2ae5530
Compare
|
Er, try now! 😁 |
|
Thanks! LGTM; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: https://github.com/dart-lang/test/blob/master/pkgs/checks/CHANGELOG.md