api [nfc]: Use Dart-standard camel case throughout our source code

README.md

@@ -49,10 +49,9 @@ to use, and [download a `.zuliprc` file][download-zuliprc].  Then
 create a file `lib/credential_fixture.dart` in this worktree with the
 following form:
 ```dart
-// ignore_for_file: constant_identifier_names
-const String realm_url = '…';
+const String realmUrl = '…';
 const String email = '…';
-const String api_key = '…';
+const String apiKey = '…';
 ```
 
 Now build and run the app (see "Flutter help" above), and things

lib/api/model/events.dart

@@ -1,5 +1,3 @@
-// ignore_for_file: non_constant_identifier_names
-
 import 'package:json_annotation/json_annotation.dart';
 
 import 'model.dart';
@@ -46,15 +44,15 @@ class UnexpectedEvent extends Event {
 }
 
 /// A Zulip event of type `alert_words`.
-@JsonSerializable()
+@JsonSerializable(fieldRename: FieldRename.snake)
 class AlertWordsEvent extends Event {
   @override
   @JsonKey(includeToJson: true)
   String get type => 'alert_words';
 
-  final List<String> alert_words;
+  final List<String> alertWords;
 
-  AlertWordsEvent({required super.id, required this.alert_words});
+  AlertWordsEvent({required super.id, required this.alertWords});
 
   factory AlertWordsEvent.fromJson(Map<String, dynamic> json) =>
       _$AlertWordsEventFromJson(json);
@@ -75,9 +73,9 @@ class MessageEvent extends Event {
   // normalize that away in deserialization.
   //
   // The other difference in the server API between message objects in these
-  // events and in the get-messages results is that `match_content` and
-  // `match_subject` are absent here.  Already [Message.match_content] and
-  // [Message.match_subject] are optional, so no action is needed on that.
+  // events and in the get-messages results is that `matchContent` and
+  // `matchSubject` are absent here.  Already [Message.matchContent] and
+  // [Message.matchSubject] are optional, so no action is needed on that.
   final Message message;
 
   MessageEvent({required super.id, required this.message});
@@ -100,7 +98,7 @@ class MessageEvent extends Event {
   }
 }
 
-@JsonSerializable()
+@JsonSerializable(fieldRename: FieldRename.snake)
 class HeartbeatEvent extends Event {
   @override
   @JsonKey(includeToJson: true)

lib/api/model/initial_snapshot.dart

@@ -1,23 +1,21 @@
-// ignore_for_file: non_constant_identifier_names
-
 import 'package:json_annotation/json_annotation.dart';
 
 import 'model.dart';
 
 part 'initial_snapshot.g.dart';
 
 // https://zulip.com/api/register-queue#response
-@JsonSerializable()
+@JsonSerializable(fieldRename: FieldRename.snake)
 class InitialSnapshot {
-  final String? queue_id;
-  final int last_event_id;
-  final int zulip_feature_level;
-  final String zulip_version;
-  final String? zulip_merge_base; // TODO(server-5)
+  final String? queueId;
+  final int lastEventId;
+  final int zulipFeatureLevel;
+  final String zulipVersion;
+  final String? zulipMergeBase; // TODO(server-5)
 
-  final List<String> alert_words;
+  final List<String> alertWords;
 
-  final List<CustomProfileField> custom_profile_fields;
+  final List<CustomProfileField> customProfileFields;
 
   // TODO etc., etc.
 
@@ -26,13 +24,13 @@ class InitialSnapshot {
   // TODO etc., etc.
 
   InitialSnapshot({
-    this.queue_id,
-    required this.last_event_id,
-    required this.zulip_feature_level,
-    required this.zulip_version,
-    this.zulip_merge_base,
-    required this.alert_words,
-    required this.custom_profile_fields,
+    this.queueId,
+    required this.lastEventId,
+    required this.zulipFeatureLevel,
+    required this.zulipVersion,
+    this.zulipMergeBase,
+    required this.alertWords,
+    required this.customProfileFields,
     required this.subscriptions,
   });