content: Open links externally on iOS #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
reviewed
Mar 20, 2024
There was a problem hiding this comment.
Thanks @rajveermalviya! This looks good except a couple of formatting nits below. I'll fix those and merge.
(The CI failure is #575. But tools/check passes for me locally, on an appropriate version of Flutter, so all's well.)
lib/widgets/content.dart
Outdated
| @@ -895,7 +896,14 @@ void _launchUrl(BuildContext context, String urlString) async { | |||
| bool launched = false; | |||
| String? errorMessage; | |||
| try { | |||
| launched = await ZulipBinding.instance.launchUrl(url); | |||
| launched = await ZulipBinding.instance.launchUrl(url, mode: switch (defaultTargetPlatform) { | |||
There was a problem hiding this comment.
nit: line too long:
Suggested change
| launched = await ZulipBinding.instance.launchUrl(url, mode: switch (defaultTargetPlatform) { | |
| launched = await ZulipBinding.instance.launchUrl(url, | |
| mode: switch (defaultTargetPlatform) { |
lib/widgets/content.dart
Outdated
Comment on lines
900
to
901
| // On iOS we prefer LaunchMode.externalApplication because LaunchMode.platformDefault | ||
| // uses SFSafariViewController which provides a weird UX for reasons mentioned |
There was a problem hiding this comment.
nit: lines too long
(and ditto for the same text in the commit message)
On iOS we prefer LaunchMode.externalApplication because (for HTTP URLs) LaunchMode.platformDefault uses SFSafariViewController, which gives an awkward UX as described here: https://chat.zulip.org/#narrow/stream/48-mobile/topic/in-app.20browser/near/1169118 Fixes: zulip#280
gnprice
force-pushed
the
ios-external-link
branch
from
c4d78cd to
c4c1a61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS we prefer LaunchMode.externalApplication because LaunchMode.platformDefault uses SFSafariViewController which provides a weird UX for reasons mentioned in this discussion.
Fixes: #280