Skip to content

Exclude deactivated users from @-mention autocomplete popup #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Khader-1
Copy link
Collaborator

Implementing #451

Logic Implemented

  • Always exclude the users that have isActive set to false
  • Show the id in the mention string if there are two users with the same full name even if one of them is deactivated

@sm-sayedi
Copy link
Collaborator

@Khader-1 Before the maintainers can review the PR, please check the zulip commit discipline page on how to properly structure your commit. 🙂

@Khader-1
Copy link
Collaborator Author

@Khader-1 Before the maintainers can review the PR, please check the zulip commit discipline page on how to properly structure your commit. 🙂

Thanks for the feedback! On it..

@Khader-1 Khader-1 closed this Mar 24, 2024
@Khader-1 Khader-1 deleted the exclude-deactivated-users-from-mention-autocomplete branch March 24, 2024 08:05
@gnprice
Copy link
Member

gnprice commented Mar 25, 2024

For cross-reference: it looks like this became #588 ah, no, #582.

@Khader-1 For future pull requests, it's better to update the existing PR than to close it and open a new one. See https://zulip.readthedocs.io/en/latest/git/pull-requests.html#update-a-pull-request .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants