urls [nfc]: Represent realm URL as Uri object, not String #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
approved these changes
Apr 18, 2023
Comment on lines
+56
to
+74
| final url = auth.realmUrl.replace( | ||
| path: "/api/v1/$route", queryParameters: encodeParameters(params)); |
There was a problem hiding this comment.
This version is implicitly assuming that realmUrl.fragment is empty.
Similarly the code in post and in the two other routes is assuming query and fragment are both empty. (In those, the old code was also assuming that, though differently so.)
That assumption is fine, but let's make it explicit with an assert. Can put it on the Auth constructor:
Auth({required this.realmUrl, required this.email, required this.apiKey})
: assert(realmUrl.query.isEmpty && realmUrl.fragment.isEmpty);
chrisbobbe
force-pushed
the
pr-uri-objects
branch
from
ad51399 to
9152167
Compare
|
Thanks for the review! Revision pushed, resolving a conflict with #63. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.