content: Handle bold-text setting in code blocks and error-unimplementeds #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teds Code blocks and _errorUnimplemented were setting their own weightVariableTextStyle without passing a BuildContext, which meant the styles didn't condition on the device setting. But weightVariableTextStyle is already applied, in a DefaultTextStyle that wraps the whole message list. (That's because that DefaultTextStyle wants to set a font, kDefaultFontFamily, that's also variable-weight.) So the clobbering ones aren't necessary; remove them. Fixes: zulip#690
chrisbobbe
added
a-content
chrisbobbe
changed the title
|
Thanks! Looks good; merging, with one nit: because I'd read "remove some parameters" to mean changing the signature of a function, rather than some of its call sites. See: (It's common to use the terms interchangeably and context usually makes the meaning clear, but here in the terseness of a summary line there's not much context.) |
gnprice
force-pushed
the
pr-code-block-bold-setting
branch
from
d72d39e to
fd32618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots show the app with the system bold text setting on.
Fixes: #690