Skip to content

Make StreamColorSwatches.lerp and CodeBlockTextStyles.lerp static #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 26, 2024
Merged

Make StreamColorSwatches.lerp and CodeBlockTextStyles.lerp static #759

merged 6 commits into from
Jun 26, 2024

Conversation

chrisbobbe
Copy link
Collaborator

Discussion:
#746 (comment)

@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Jun 21, 2024
@chrisbobbe chrisbobbe requested a review from gnprice June 21, 2024 23:31
gnprice
gnprice approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@gnprice gnprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup! LGTM.

It looks like this will have a merge conflict with #756 that might be a bit annoying. Feel free to merge this first, or to hold it for after merging that, whichever seems easier.

@chrisbobbe chrisbobbe force-pushed the pr-make-lerps-static branch from e4159f3 to d361112 Compare June 26, 2024 07:28
@chrisbobbe chrisbobbe force-pushed the pr-make-lerps-static branch from d361112 to 0399af6 Compare June 26, 2024 07:28
@chrisbobbe chrisbobbe merged commit 0399af6 into zulip:main Jun 26, 2024
1 check passed
@chrisbobbe chrisbobbe deleted the pr-make-lerps-static branch June 26, 2024 07:29
@chrisbobbe
Copy link
Collaborator Author

Thanks! Merged.

@chrisbobbe chrisbobbe mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnprice gnprice gnprice approved these changes

Assignees
No one assigned
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisbobbe @gnprice