msglist: Simplify safe-area handling; fix a small bug #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user-visible effect was pretty small, so I didn't debug it fully in PR zulip#3: on my iPhone, before this commit, scrolling all the way down in the message list left about a centimeter, maybe less, between the bottom of the latest message and the top of the compose-box placeholder. Now, on my iPhone, scrolling down puts the bottom edge of the latest message flush with the top of the compose-box placeholder, as has been the case on devices without insets. I'm not sure if that's quite the effect we want, but if we want to add padding, we should do it on purpose. Addressing Greg's TODO in 88f3b73 would have prevented this bug from sneaking in; I'll take care of that next: // TODO have MessageListPage adjust the MediaQuery so we don't // have to worry about this here
This addresses Greg's TODO in 88f3b73: // TODO have MessageListPage adjust the MediaQuery so we don't // have to worry about this here Not seeing (experimentally) any more bugs like the one fixed in the previous commit, I'm marking this NFC.
chrisbobbe
force-pushed
the
pr-simplify-safe-area-handling
branch
from
2efb06c to
11a4b15
Compare
|
Revision pushed, with 11a4b15 widgets/app [nfc]: Smoothen a wrinkle about MediaQuery.removePadding (I recently learned about the |
gnprice
reviewed
Feb 14, 2023
lib/widgets/app.dart
Outdated
| // The compose box pads the bottom inset. | ||
| removeBottom: true, | ||
|
|
||
| child: const Expanded(child: MessageList())), |
There was a problem hiding this comment.
The MessageList gets a bit lost here for me, visually — that is, it's easy to miss when looking for the main payload of this widget tree. Let's give it its own line:
Suggested change
| child: const Expanded(child: MessageList())), | |
| child: const Expanded( | |
| child: MessageList())), |
lib/widgets/app.dart
Outdated
| child: const Expanded(child: MessageList())), | ||
| const SizedBox( | ||
| height: 80, | ||
| child: Center(child: Text("(Compose box goes here.)")))])))); |
There was a problem hiding this comment.
Similarly:
Suggested change
| child: Center(child: Text("(Compose box goes here.)")))])))); | |
| child: Center( | |
| child: Text("(Compose box goes here.)")))])))); |
lib/widgets/app.dart
Outdated
| child: Center(child: Text("(Compose box goes here.)"))), | ||
| ]))); | ||
|
|
||
| // See MediaQuery.removePadding for why we need this BuildContext. |
There was a problem hiding this comment.
This comment can be dropped; when a reader wants to know why we need this BuildContext, they'll naturally look to where it's used, and that tells them the same information that's in the comment.
chrisbobbe
force-pushed
the
pr-simplify-safe-area-handling
branch
from
11a4b15 to
57294ea
Compare
|
Thanks for the review! Revision pushed. |
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Greg's TODO in 88f3b73:
// TODO have MessageListPage adjust the MediaQuery so we don't
// have to worry about this here
with a bugfix beforehand, so that resolving the TODO is NFC (or at least seems to be, experimentally).