Skip to content

msglist: Provide narrow to MessageListPage descendants #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Jul 13, 2024

This is a draft only because I haven't yet written tests for it, and I'm going AFK in a couple of minutes but want to provide this now for #779 to build on per #779 (comment) .

@gnprice gnprice requested a review from chrisbobbe July 13, 2024 17:31
@gnprice gnprice force-pushed the pr-msglist-narrow branch from 0602b4f to f587684 Compare July 15, 2024 20:49
@gnprice gnprice marked this pull request as ready for review July 15, 2024 20:49
@gnprice
Copy link
Member Author

gnprice commented Jul 15, 2024

OK, tests written, and this is ready for review.

@gnprice gnprice added the maintainer review PR ready for review by Zulip maintainers label Jul 15, 2024
@chrisbobbe chrisbobbe merged commit 7285325 into zulip:main Jul 17, 2024
@chrisbobbe
Copy link
Collaborator

Thanks, LGTM! Merged.

@gnprice gnprice deleted the pr-msglist-narrow branch July 17, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants