poll: Support read-only poll widget UI. #912
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter_gen/gen_l10n/zulip_localizations.dart'; | ||
|
|
||
| import '../api/model/submessage.dart'; | ||
| import 'content.dart'; | ||
| import 'store.dart'; | ||
| import 'text.dart'; | ||
|
|
||
| class PollWidget extends StatefulWidget { | ||
| const PollWidget({super.key, required this.poll}); | ||
|
|
||
| final Poll poll; | ||
|
|
||
| @override | ||
| State<PollWidget> createState() => _PollWidgetState(); | ||
| } | ||
|
|
||
| class _PollWidgetState extends State<PollWidget> { | ||
| @override | ||
| void initState() { | ||
| super.initState(); | ||
| widget.poll.addListener(_modelChanged); | ||
| } | ||
|
|
||
| @override | ||
| void didUpdateWidget(covariant PollWidget oldWidget) { | ||
| super.didUpdateWidget(oldWidget); | ||
| if (widget.poll != oldWidget.poll) { | ||
| oldWidget.poll.removeListener(_modelChanged); | ||
| widget.poll.addListener(_modelChanged); | ||
| } | ||
| } | ||
|
|
||
| @override | ||
| void dispose() { | ||
| widget.poll.removeListener(_modelChanged); | ||
| super.dispose(); | ||
| } | ||
|
|
||
| void _modelChanged() { | ||
| setState(() { | ||
| // The actual state lives in the [Poll] model. | ||
| // This method was called because that just changed. | ||
| }); | ||
| } | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| final zulipLocalizations = ZulipLocalizations.of(context); | ||
| final theme = ContentTheme.of(context); | ||
| final store = PerAccountStoreWidget.of(context); | ||
|
|
||
| final textStyleBold = const TextStyle(fontSize: 18) | ||
| .merge(weightVariableTextStyle(context, wght: 600)); | ||
| final textStyleVoterNames = TextStyle( | ||
| fontSize: 16, color: theme.colorPollNames); | ||
|
|
||
| Text question = (widget.poll.question.isNotEmpty) | ||
| ? Text(widget.poll.question, style: textStyleBold) | ||
| : Text(zulipLocalizations.pollWidgetQuestionMissing, | ||
| style: textStyleBold.copyWith(fontStyle: FontStyle.italic)); | ||
|
|
||
| Widget buildOptionItem(PollOption option) { | ||
| // TODO(i18n): List formatting, like you can do in JavaScript: | ||
| // new Intl.ListFormat('ja').format(['Chris', 'Greg', 'Alya', 'Zixuan']) | ||
| // // 'Chris、Greg、Alya、Zixuan' | ||
| final voterNames = option.voters | ||
| .map((userId) => | ||
| store.users[userId]?.fullName ?? zulipLocalizations.unknownUserName) | ||
| .join(', '); | ||
|
There was a problem hiding this comment. Indented this in a style taken from @override
List<DiagnosticsNode> debugDescribeChildren() {
return items
.mapIndexed((i, nodes) =>
_BlockContentListNode(nodes).toDiagnosticsNode(name: 'item $i'))
.toList();
} |
||
|
|
||
| return Padding( | ||
| padding: const EdgeInsets.only(bottom: 5), | ||
| child: Row( | ||
| spacing: 5, | ||
| crossAxisAlignment: CrossAxisAlignment.baseline, | ||
| textBaseline: localizedTextBaseline(context), | ||
| children: [ | ||
| ConstrainedBox( | ||
| constraints: const BoxConstraints(minWidth: 25), | ||
| child: Container( | ||
| height: 25, | ||
| padding: const EdgeInsets.symmetric(horizontal: 4), | ||
| decoration: BoxDecoration( | ||
| color: theme.colorPollVoteCountBackground, | ||
| border: Border.all(color: theme.colorPollVoteCountBorder), | ||
| borderRadius: BorderRadius.circular(3)), | ||
| child: Center( | ||
| child: Text(option.voters.length.toString(), | ||
| textAlign: TextAlign.center, | ||
| style: textStyleBold.copyWith( | ||
| color: theme.colorPollVoteCountText, fontSize: 13))))), | ||
| Expanded( | ||
| child: Wrap( | ||
| spacing: 5, | ||
| children: [ | ||
| Text(option.text, style: textStyleBold.copyWith(fontSize: 16)), | ||
| if (option.voters.isNotEmpty) | ||
| // TODO(i18n): Localize parenthesis characters. | ||
| Text('($voterNames)', style: textStyleVoterNames), | ||
| ])), | ||
| ])); | ||
| } | ||
|
|
||
| return Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: [ | ||
| Padding(padding: const EdgeInsets.only(bottom: 6), child: question), | ||
| if (widget.poll.options.isEmpty) | ||
| Text(zulipLocalizations.pollWidgetOptionsMissing, | ||
| style: textStyleVoterNames.copyWith(fontStyle: FontStyle.italic)), | ||
| for (final option in widget.poll.options) | ||
| buildOptionItem(option), | ||
| ]); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is pretty short, I'm not sure if we need a better way to organize
ZulipMessageContent,PollContent, andMessageContent. The filelib/model/content.dartis predominantly about our AST for Zulip HTML content.