deps: Add some overrides to unblock Flutter Color API changes for wide-gamut #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-gamut This commit follows the request in flutter/flutter#154123 by pointing to a Flutter maintainer's fork of `flutter_color_model` and `color_model` while we wait for their PR from that fork to be settled. To validate this change, I checked out the roll from engine-flutter-autoroll that failed on our tests: flutter/flutter#153985 and confirmed that our tests (the ones that run with `tools/check test --all`) failed with same-looking errors before this change and passed after this change. I did run all of `tools/check --all`, not just the `test` suite. There was "info"-level output from the analyzer telling us about things we've been using that will be deprecated with the proposed Color API change (`Color.value` and `Color.withOpacity`). We'll want to respond promptly to these deprecation notices -- and in fact our CI treats this "info"-level output as an error -- but I think we can leave that out of scope for the customer-tests fix, because we've set it so "info"-level analyzer output isn't fatal there: flutter/tests@54cc35f9f#diff-d2bef7bb93d58c3db877456685dad3e25d1546c1fc318e9d6c560e91c457eaa7R10
|
I think it is concerning that we rely on packages whose maintainer does not seem to be active anymore. Maybe that's a sign that we should eventually drop the dependency after this fix, but I'm not sure how much work that will be. |
|
Tested and could verify that the fix works. LGTM! |
|
Thanks for the review! Merging.
Interesting, yeah. I guess a helpful signal for the maintainer's engagement will be to see how quickly they respond to james-alex/color_models#10 . 🙂 |
chrisbobbe
added a commit
to chrisbobbe/tests
that referenced
this pull request
Aug 28, 2024
gaaclarke
pushed a commit
to flutter/tests
that referenced
this pull request
Aug 29, 2024
|
Thanks everyone for moving on this quickly. This is kind of a weird flow, forward fixing things. It tested fine locally so hopefully I got everything right 🤞 |
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Aug 31, 2024
And update Flutter's supporting libraries to match. Also, as anticipated in zulip#920 (see PR description), handle some deprecations in the Color API from flutter/engine@eff1b76cf (rolled in flutter/flutter@8c1a93508). Deprecation warnings are "info"-level in analyzer output, and CI treats that as fatal, because we don't want to let those hang around. In particular: - `withOpacity` is replaced with the new `withValues` - `value` is deprecated (we did most of the work to handle this in a recent commit; here we just add an `ignore:` for one place we're still using it).
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Sep 7, 2024
And update Flutter's supporting libraries to match. Also, as anticipated in zulip#920 (see PR description), handle some deprecations in the Color API from flutter/engine@eff1b76cf (rolled in flutter/flutter@8c1a93508). Deprecation warnings are "info"-level in analyzer output, and CI treats that as fatal, because we don't want to let those hang around. In particular, `withOpacity` is replaced with the new `withValues`. Also, `value` is newly deprecated, but we migrated off that in the previous commit.
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Sep 7, 2024
And update Flutter's supporting libraries to match. Also, as anticipated in zulip#920 (see PR description), handle some deprecations in the Color API from flutter/engine@eff1b76cf (rolled in flutter/flutter@8c1a93508). Deprecation warnings are "info"-level in analyzer output, and CI treats that as fatal, because we don't want to let those hang around. In particular, `withOpacity` is replaced with the new `withValues`. Also, `value` is newly deprecated, but we migrated off that in the previous commit.
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Sep 7, 2024
And update Flutter's supporting libraries to match. Also, as anticipated in zulip#920 (see PR description), handle some deprecations in the Color API from flutter/engine@eff1b76cf (rolled in flutter/flutter@8c1a93508). Deprecation warnings are "info"-level in analyzer output, and CI treats that as fatal, because we don't want to let those hang around. In particular, `withOpacity` is replaced with the new `withValues`. Also, `value` is newly deprecated, but we migrated off that in the previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit follows the request in
flutter/flutter#154123
by pointing to a Flutter maintainer's fork of
flutter_color_modelandcolor_modelwhile we wait for their PR from that fork to be settled.To validate this change, I checked out the roll from engine-flutter-autoroll that failed on our tests:
flutter/flutter#153985
and confirmed that our tests (the ones that run with
tools/check test --all) failed with same-looking errors before this change and passed after this change.I did run all of
tools/check --all, not just thetestsuite. There was "info"-level output from the analyzer telling us about things we've been using that will be deprecated with the proposed Color API change (Color.valueandColor.withOpacity). We'll want to respond promptly to these deprecation notices -- and in fact our CI treats this "info"-level output as an error -- but I think we can leave that out of scope for the customer-tests fix, because we've set it so "info"-level analyzer output isn't fatal there:flutter/tests@54cc35f9f#diff-d2bef7bb93d58c3db877456685dad3e25d1546c1fc318e9d6c560e91c457eaa7R10