Rename "night mode" to "dark theme"

[timabbott]

As discussed in #19728, we should rename "night mode" to "dark theme" across the UI. See a28c69c an incomplete first effort towards this.

Here's a proposal for what we change, each as its own commit:

• Change "Automatic" to "Sync with computer" as the label for the "automatic" option in settings -- that's a lot more clear about what this it does for humans. We can keep the automatic internal value; that's clear enough for developers.
• Rename the file night-mode.md in the Help Center to dark-theme.md, and include a redirect. 302aba0 is a sample similar commit. Use git grep night_mode.md to make sure we update all references in this commit. This commit should make no other changes.
• Rename night-mode.css to dark-theme.css; use git grep night-mode.css to make sure we update all references.
• Change "Night mode" => "Dark theme" everywhere it appears in text (use git grep -i "night mode" to find references). (skip locale, since those are generated translation files).
• Change the handful of new "Dark mode" labels in the typeahead to "Dark theme", and similarly for the light one. And perhaps also change the descriptions to be something clearer like "Switch to the dark theme."

We'll probably want to do 5-10 more renaming commits afterwards, but I think that is a pretty long series for someone who may be new to building commit series like this, where one carefully only changes one class of thing in each commit to make one's work easy to verify and review.

[zulipbot]

Hello @zulip/server-settings members, this issue was labeled with the "area: settings (user)" label, so you may want to check it out!

[andersk]

I thought the conclusion of https://chat.zulip.org/#narrow/stream/9-issues/topic/day.2Fnight.20slash.20commands was that we wanted to rename “night” to “dark”, not the other way around?

(Edited this in, since the previous text was inconsistent with itself.)

[anjalivats2712]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @anjalivats2712! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[NerdyLucifer]

@timabbott may i work on this issue?

[timabbott]

I think I'd like an experienced contributor to work on this since it's a release goal; @sahil839 can you take this issue?

[sahil839]

Sure.

[timabbott]

@sahil839 I think what's left may be mostly comments, but git grep -i dark[_ ]mode and similar things still find a good number of comments that need tweaking.

[sahil839]

Apart from comments, do we want to change the classes and ids of elements? And also the js file is still named as night_mode.

[timabbott]

I'd at least rename the file to dark_theme.ts, and if it's easy, change all the classes/IDs as well. I don't think we're likely to undo the changes, and it's just technical debt having both names floating around.

[timabbott]

@sahil839 is there anything else left for this issue?

[sahil839]

Opened #20441 for a minor renaming of tests.

We use variables like realm_night_logo_source, realm_night_logo_url. Basically we use night in some variables in the realm-logo related code. Other than this, we have renamed everything.

[timabbott]

Yeah, I think that's maybe worth discussing in #api design whether it's worth renaming; I can see arguments either way. Want to start a thread?

[timabbott]

I think we can close this with #20441; and just decide if we want the little API churn there -- we might since I think those fields are likely only used by the web app at this point, and thus it's cheap to clean up.