-
Notifications
You must be signed in to change notification settings - Fork 970
Unify variable instructions and handle local variables #6459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee0b072
to
8965c1a
Compare
4ian
reviewed
Mar 16, 2024
@@ -1298,7 +1298,20 @@ gd::String EventsCodeGenerator::GenerateGetVariable( | |||
const gd::String& objectName) { | |||
gd::String output; | |||
const gd::VariablesContainer* variables = NULL; | |||
if (scope == LAYOUT_VARIABLE) { | |||
if (scope == ANY_VARIABLE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be interesting to see if we can pass here a VariablesContainersList at some point so the work of scoping is always done by a method of VariablesContainersList.
769c0fb
to
df3232c
Compare
b466237
to
0a85259
Compare
Merged
D8H
commented
Apr 24, 2024
D8H
commented
Apr 24, 2024
D8H
commented
Apr 25, 2024
D8H
commented
Apr 25, 2024
4ian
reviewed
Apr 25, 2024
4ian
reviewed
Apr 26, 2024
4ian
reviewed
Apr 26, 2024
4ian
reviewed
Apr 26, 2024
4ian
reviewed
Apr 26, 2024
4ian
reviewed
Apr 26, 2024
4ian
reviewed
Apr 26, 2024
4ian
reviewed
Apr 26, 2024
4ian
reviewed
Apr 26, 2024
4ian
reviewed
Apr 26, 2024
4ian
reviewed
Apr 26, 2024
4ian
reviewed
May 20, 2024
4ian
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Out of scope
Demo
This command can help to migrate a project (which is not mandatory to do).
You will still have to: