Unify variable instructions and handle local variables

Core/GDCore/Events/Builtin/StandardEvent.cpp

@@ -15,7 +15,8 @@ using namespace std;
 
 namespace gd {
 
-StandardEvent::StandardEvent() : BaseEvent() {}
+StandardEvent::StandardEvent()
+    : BaseEvent(), variables(gd::VariablesContainer::SourceType::Local) {}
 
 StandardEvent::~StandardEvent(){};
 
@@ -57,6 +58,9 @@ void StandardEvent::SerializeTo(SerializerElement& element) const {
   if (!events.IsEmpty())
     gd::EventsListSerialization::SerializeEventsTo(events,
                                                   element.AddChild("events"));
+  if (HasVariables()) {
+    variables.SerializeTo(element.AddChild("variables"));
+  }
 }
 
 void StandardEvent::UnserializeFrom(gd::Project& project,
@@ -71,6 +75,11 @@ void StandardEvent::UnserializeFrom(gd::Project& project,
     gd::EventsListSerialization::UnserializeEventsFrom(
         project, events, element.GetChild("events", 0, "Events"));
   }
+
+  variables.Clear();
+  if (element.HasChild("variables")) {
+    variables.UnserializeFrom(element.GetChild("variables"));
+  }
 }
 
 }  // namespace gd

Core/GDCore/Events/Builtin/StandardEvent.h

@@ -4,13 +4,13 @@
  * reserved. This project is released under the MIT License.
  */
 
-#if defined(GD_IDE_ONLY)
-#ifndef GDCORE_STANDARDEVENT_H
-#define GDCORE_STANDARDEVENT_H
+#pragma once
+
 #include "GDCore/Events/Event.h"
 #include "GDCore/Events/EventsList.h"
 #include "GDCore/Events/Instruction.h"
 #include "GDCore/Events/InstructionsList.h"
+#include "GDCore/Project/VariablesContainer.h"
 namespace gd {
 class Instruction;
 class Project;
@@ -33,6 +33,10 @@ class GD_CORE_API StandardEvent : public gd::BaseEvent {
   virtual const gd::EventsList& GetSubEvents() const { return events; };
   virtual gd::EventsList& GetSubEvents() { return events; };
 
+  virtual bool CanHaveVariables() const { return true; }
+  virtual const gd::VariablesContainer& GetVariables() const { return variables; };
+  virtual gd::VariablesContainer& GetVariables() { return variables; };
+
   const gd::InstructionsList& GetConditions() const { return conditions; };
   gd::InstructionsList& GetConditions() { return conditions; };
 
@@ -53,9 +57,7 @@ class GD_CORE_API StandardEvent : public gd::BaseEvent {
   gd::InstructionsList conditions;
   gd::InstructionsList actions;
   EventsList events;
+  VariablesContainer variables;
 };
 
 }  // namespace gd
-
-#endif  // GDCORE_STANDARDEVENT_H
-#endif

Core/GDCore/Events/CodeGeneration/DiagnosticReport.h

@@ -0,0 +1,115 @@
+/*
+ * GDevelop Core
+ * Copyright 2008-present Florian Rival ([email protected]). All rights
+ * reserved. This project is released under the MIT License.
+ */
+#pragma once
+
+#include <memory>
+#include <vector>
+
+#include "GDCore/String.h"
+#include "GDCore/Tools/MakeUnique.h"
+
+namespace gd {
+
+/**
+ * \brief 
+ */
+class GD_CORE_API ProjectDiagnostic {
+public:
+  enum ErrorType {
+    UndeclaredVariable,
+    MissingBehavior
+  };
+
+  ProjectDiagnostic(ErrorType type_, const gd::String &message_,
+                    const gd::String &actualValue_,
+                    const gd::String &expectedValue_, const gd::String &objectName_)
+      : type(type_), message(message_), actualValue(actualValue_), expectedValue(expectedValue_),
+        objectName(objectName_){};
+  virtual ~ProjectDiagnostic(){};
+
+  ErrorType GetType() const { return type; };
+  const gd::String &GetMessage() const { return message; }
+  const gd::String &GetObjectName() const { return objectName; }
+  const gd::String &GetActualValue() const { return actualValue; }
+  const gd::String &GetExpectedValue() const { return expectedValue; }
+
+private:
+  ErrorType type;
+  gd::String message;
+  gd::String objectName;
+  gd::String actualValue;
+  gd::String expectedValue;
+};
+
+/**
+ * \brief 
+ */
+class GD_CORE_API DiagnosticReport {
+public:
+  DiagnosticReport(){};
+  virtual ~DiagnosticReport(){};
+
+  void Add(const gd::ProjectDiagnostic &projectDiagnostic) {
+    projectDiagnostics.push_back(
+        gd::make_unique<gd::ProjectDiagnostic>(projectDiagnostic));
+  };
+
+  const ProjectDiagnostic &Get(std::size_t index) const {
+    return *projectDiagnostics[index].get();
+  };
+
+  std::size_t Count() const { return projectDiagnostics.size(); };
+
+  const gd::String &GetSceneName() const { return sceneName; }
+
+  void SetSceneName(const gd::String &sceneName_) {
+    sceneName = sceneName_;
+  }
+
+private:
+  std::vector<std::unique_ptr<gd::ProjectDiagnostic>> projectDiagnostics;
+  gd::String sceneName;
+};
+
+/**
+ * \brief 
+ */
+class GD_CORE_API WholeProjectDiagnosticReport {
+public:
+  WholeProjectDiagnosticReport(){};
+  virtual ~WholeProjectDiagnosticReport(){};
+
+  const DiagnosticReport &Get(std::size_t index) const {
+    return *diagnosticReports[index].get();
+  };
+
+  void Clear() {
+    diagnosticReports.clear();
+  };
+
+  DiagnosticReport& AddNewDiagnosticReportForScene(const gd::String &sceneName) {
+    auto diagnosticReport = gd::make_unique<gd::DiagnosticReport>();
+    diagnosticReport->SetSceneName(sceneName);
+    diagnosticReports.push_back(std::move(diagnosticReport));
+    return *diagnosticReports[diagnosticReports.size() - 1].get();
+  };
+
+  std::size_t Count() const { return diagnosticReports.size(); };
+
+  bool HasAnyIssue() {
+    for (auto& diagnosticReport : diagnosticReports) {
+      if (diagnosticReport->Count() > 0) {
+        return true;
+      }
+    }
+    return false;
+  }
+
+private:
+  std::vector<std::unique_ptr<gd::DiagnosticReport>> diagnosticReports;
+};
+
+} // namespace gd

Core/GDCore/Events/CodeGeneration/EventsCodeGenerationContext.h

@@ -3,8 +3,8 @@
  * Copyright 2008-2016 Florian Rival ([email protected]). All rights
  * reserved. This project is released under the MIT License.
  */
-#ifndef EVENTSCODEGENERATIONCONTEXT_H
-#define EVENTSCODEGENERATIONCONTEXT_H
+#pragma once
+
 #include <map>
 #include <memory>
 #include <set>
@@ -325,4 +325,3 @@ class GD_CORE_API EventsCodeGenerationContext {
 };
 
 }  // namespace gd
-#endif  // EVENTSCODEGENERATIONCONTEXT_H