Skip to content

Disable PSA in baremetal profiles #10002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2019
Merged

Disable PSA in baremetal profiles #10002

merged 1 commit into from
Mar 8, 2019

Conversation

kegilbert
Copy link
Contributor

@kegilbert kegilbert commented Mar 7, 2019 •
edited
Loading

Description

Allows BareMetal profiles to build when PSA is present on master. Currently breaks baremetal compiles without this.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SenRamakri @theotherjimmy @orenc17

Release Notes

orenc17
orenc17 suggested changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@orenc17 orenc17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just remove PSA from extra labels?

@ghost ghost added the PM_ACCEPTED label Mar 7, 2019
@kegilbert kegilbert changed the title Add PSA lib file Disable PSA in baremetal profiles Mar 7, 2019
ghost
ghost approved these changes Mar 7, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets criteria, needed to support new feature PSA & Bare Metal. Approved.

@orenc17
Copy link
Contributor

orenc17 commented Mar 7, 2019

@kegilbert @ChiefBureaucraticOfficer which platform is broken on bare-metal?

mikisch81
mikisch81 suggested changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@mikisch81 mikisch81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be verified on #9910 that it does not break the secure target build.
@mmahadevan108 FYI

@kegilbert kegilbert force-pushed the psa_baremetal_fix branch from 49d738b to 3fd3288 Compare March 7, 2019 22:42
@kegilbert
Copy link
Contributor Author

@orenc17 PSA compliant targets are broken (specifically found the issue on the K64F).

orenc17
orenc17 approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@orenc17 orenc17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me @kegilbert supplied build log with #9910
@ARMmbed/mbed-os-maintainers i would still prefer to merge this AFTER #9910 is merged

P.S. sorry for the caps...i get cranky code reviewing at 1AM

@cmonr
Copy link
Contributor

cmonr commented Mar 8, 2019 •
edited
Loading

i get cranky code reviewing at 1AM

Mabe you should get some sleep 😁

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2019

Starting CI

@cmonr
Copy link
Contributor

cmonr commented Mar 8, 2019

@ARMmbed/mbed-os-maintainers i would still prefer to merge this AFTER #9910 is merged

@orenc17
Copy link
Contributor

orenc17 commented Mar 8, 2019

@cmonr Beware, people will think you're angry

@ARMmbed/mbed-os-maintainers i would still prefer to merge this AFTER #9910 is merged

@mbed-ci
Copy link

mbed-ci commented Mar 8, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Mar 8, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2019

#9910 merged, can this go in?

@orenc17
Copy link
Contributor

orenc17 commented Mar 8, 2019

Yes

@0xc0170 0xc0170 merged commit b9c214b into ARMmbed:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikisch81 mikisch81 mikisch81 requested changes

@0xc0170 0xc0170 0xc0170 approved these changes

@orenc17 orenc17 orenc17 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kegilbert @orenc17 @cmonr @0xc0170 @mbed-ci @mikisch81