Add support for LPC55S59 #9910

mmahadevan108 · 2019-03-02T12:37:52Z

Description

Cortex-M33 based platform. I will submit my test results.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

mmahadevan108 · 2019-03-02T12:40:10Z

cc @orenc17 @mikisch81 @maclobdell @0xc0170 @cmonr @deepikabhavnani

mmahadevan108 · 2019-03-02T12:43:01Z

cc @AndreyButokNXP @nxp49431

mmahadevan108 · 2019-03-02T12:53:48Z

LPC55S69_IAR.txt
LPC55S69_GCC_ARM.txt
LPC55S69_ARM.txt

mmahadevan108 · 2019-03-02T12:58:25Z

The mbed-os-tests-mbed_platform-wait_ns test is failing.

[1551529466.18][CONN][RXD] >>> Running case #1: 'Test: wait_ns - compare with us_timer 1s'...
[1551529466.24][CONN][INF] found KV pair in stream: {{__testcase_start;Test: wait_ns - compare with us_timer 1s}}, queued...
mbedgt: :75::FAIL: Expected 1.200000 Was 0.602970
[1551529466.87][CONN][RXD] :75::FAIL: Expected 1.200000 Was 0.602970

I see the below comment in the wait_ns code inside mbed_wait_api_no_rtos.c file

// TODO - check M33

Can someone from ARM team take a look at the test failure and see if the mbed code needs to be updated?

mmahadevan108 · 2019-03-02T13:05:10Z

The mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack test fails only under GCC_ARM. I had spoken with @deepikabhavnani about updating the test case to increase the check range.

mmahadevan108 · 2019-03-02T13:09:00Z

I am working with @orenc17 @mikisch81 @maclobdell on the below failures:
mbed-os-features-storage-tests-blockdevice-general_block_device
mbed-os-features-storage-tests-kvstore-direct_access_devicekey_test
mbed-os-tests-mbed-crypto-sanity
mbed-os-tests-mbed_hal-spm
mbed-os-tests-psa-attestation
mbed-os-tests-psa-crypto_access_control
mbed-os-tests-psa-entropy_inject
mbed-os-tests-psa-its_ps

mikisch81 · 2019-03-02T13:12:38Z

The mbed-os-tests-mbed_platform-wait_ns test is failing.

[1551529466.18][CONN][RXD] >>> Running case #1: 'Test: wait_ns - compare with us_timer 1s'...
[1551529466.24][CONN][INF] found KV pair in stream: {{__testcase_start;Test: wait_ns - compare with us_timer 1s}}, queued...
mbedgt: :75::FAIL: Expected 1.200000 Was 0.602970
[1551529466.87][CONN][RXD] :75::FAIL: Expected 1.200000 Was 0.602970

I see the below comment in the wait_ns code inside mbed_wait_api_no_rtos.c file

// TODO - check M33

Can someone from ARM team take a look at the test failure and see if the mbed code needs to be updated?

@kjbracey-arm @deepikabhavnani

deepikabhavnani · 2019-03-02T13:39:49Z

The mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack test fails only under GCC_ARM.

Please update the test in this PR itself to check the stack pointer in entire stack range (0x400) instead 128 bytes

https://github.com/ARMmbed/mbed-os/blob/master/TESTS/mbedmicro-rtos-mbed/heap_and_stack/main.cpp#L207

ciarmcom · 2019-03-02T14:00:27Z

@mmahadevan108, thank you for your changes.
@maclobdell @MarceloSalazar @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-tools please review.

mikisch81 · 2019-03-03T17:09:21Z

@mmahadevan108
In order to simplify the building process, mainly for tests, we opened a PR to find the secure image during post-build of the non-secure target: #9894.

The usage of this can be seen here.

mikisch81 · 2019-03-03T20:21:38Z

@mmahadevan108 #9823 was merged so you can rebase.
You still need #9915, #9916 and #9894, hopefully they will be merged soon.

mikisch81 · 2019-03-03T21:16:43Z

@ARMmbed/mbed-os-maintainers this needs a 5.12.0-rc1 label

NirSonnenschein · 2019-03-04T07:16:06Z

@mmahadevan108 , please take a look at the travis failures : https://travis-ci.org/ARMmbed/mbed-os/jobs/500777066

mikisch81 · 2019-03-04T13:45:54Z

@mmahadevan108 Also you need to rebase as a lot of fixes are already upstream.

Move the clock setup and peripheral reset to the init function Signed-off-by: Mahesh Mahadevan <[email protected]>

Signed-off-by: Mahesh Mahadevan <[email protected]>

The flash driver for the LPC55S69 is different from prior LPC family. Move the Flash HAL driver to SoC specific folder Signed-off-by: Mahesh Mahadevan <[email protected]>

Signed-off-by: Mahesh Mahadevan <[email protected]>

These are defined by mbed during compile Signed-off-by: Mahesh Mahadevan <[email protected]>

Signed-off-by: Mahesh Mahadevan <[email protected]>

CTIMER 0 is used for the secure domain and CTIMER 1 is used for the non-secure domain Signed-off-by: Mahesh Mahadevan <[email protected]>

Signed-off-by: Mahesh Mahadevan <[email protected]>

… images

Signed-off-by: Mahesh Mahadevan <[email protected]>

mikisch81 · 2019-03-08T13:59:53Z

A rebase is needed as there is conflict in the tdbstore mbed_lib.json

adbridge · 2019-03-08T15:51:10Z

ci started

mbed-ci · 2019-03-08T18:07:50Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

0xc0170

Can be fixed in new PR (next patch release) - new files should contain SPDX identifier - I've noticed some hal files missing in this PR.

mmahadevan108 · 2019-03-08T22:00:32Z

LPC55S69_GCC_ARM.txt
LPC55S69_IAR.txt
LPC55S69_ARM.txt

ciarmcom requested review from maclobdell, MarceloSalazar and a team March 2, 2019 14:00

ciarmcom added the needs: review label Mar 2, 2019

mikisch81 mentioned this pull request Mar 3, 2019

PSA tools: Find secure image at post-build #9894

Merged

This was referenced Mar 3, 2019

Skip test on Cortex M33 devices #9916

Merged

Fix bug in crypto_acl test #9913

Merged

mbed-SPM updates #9823

Merged

Update TF-M sources #9915

Merged

NirSonnenschein added the release-version: 5.12.0-rc1 label Mar 4, 2019

0xc0170 requested a review from a user March 4, 2019 09:28

0xc0170 added release-version: 5.12.0-rc2 and removed release-version: 5.12.0-rc1 labels Mar 4, 2019

ghost added the PM_ACCEPTED label Mar 4, 2019

mmahadevan108 and others added 17 commits March 8, 2019 07:28

MCUXpresso: Update SPI driver

dd21e6d

Move the clock setup and peripheral reset to the init function Signed-off-by: Mahesh Mahadevan <[email protected]>

MCUXpresso: Update LPC TRNG driver

5853af7

Signed-off-by: Mahesh Mahadevan <[email protected]>

MCUXpresso: Update LPC HAL flash driver

bb2a155

The flash driver for the LPC55S69 is different from prior LPC family. Move the Flash HAL driver to SoC specific folder Signed-off-by: Mahesh Mahadevan <[email protected]>

Add support for LPC55S69

b4aaad0

Signed-off-by: Mahesh Mahadevan <[email protected]>

MCUXpresso: Update the sleep implementation for LPC55S69 differences

98c8aa1

Signed-off-by: Mahesh Mahadevan <[email protected]>

LPC55S69: Remove FPU_PRESENT and DSP_PRESENT defines

3d82af0

These are defined by mbed during compile Signed-off-by: Mahesh Mahadevan <[email protected]>

LPC55S69: Fix the I2C SDK driver

66eb3de

Signed-off-by: Mahesh Mahadevan <[email protected]>

LPC55S69: Add a ctimer for usticker to be used in the secure domain

616fa49

CTIMER 0 is used for the secure domain and CTIMER 1 is used for the non-secure domain Signed-off-by: Mahesh Mahadevan <[email protected]>

MCUXpresso: Update Analogin support

2e9bb17

Signed-off-by: Mahesh Mahadevan <[email protected]>

LPC55S69: Update the KVStore config files

c607b8a

Signed-off-by: Mahesh Mahadevan <[email protected]>

LPC55S69: Add post processing script

4573d22

Signed-off-by: Mahesh Mahadevan <[email protected]>

LPC55S69: Use find_secure_image in post-build and add prebuilt secure…

ebd9dc8

… images

LPC55S69: Change post-build hook to create HEX

401580f

Updated LOOP_SCALER value for Cortex-M33

0aa8dc2

Signed-off-by: Mahesh Mahadevan <[email protected]>

Increase the stack pointer check range

162425b

Signed-off-by: Mahesh Mahadevan <[email protected]>

Reduce the number of flash operation related veneer table entries

4a2dbba

Signed-off-by: Mahesh Mahadevan <[email protected]>

Updated the binaries

862961c

Signed-off-by: Mahesh Mahadevan <[email protected]>

mmahadevan108 force-pushed the Add_LPC55S69_TFM_mbed_master branch from 0e20f18 to 862961c Compare March 8, 2019 14:01

cmonr mentioned this pull request Mar 8, 2019

Disable PSA in baremetal profiles #10002

Merged

adbridge added needs: CI and removed needs: work labels Mar 8, 2019

0xc0170 added ready for merge and removed needs: CI labels Mar 8, 2019

0xc0170 approved these changes Mar 8, 2019

View reviewed changes

0xc0170 merged commit 0e532ba into ARMmbed:master Mar 8, 2019

0xc0170 removed the ready for merge label Mar 8, 2019

Add support for LPC55S59 #9910

Add support for LPC55S59 #9910

Uh oh!

Conversation

mmahadevan108 commented Mar 2, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

mmahadevan108 commented Mar 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmahadevan108 commented Mar 2, 2019

Uh oh!

mmahadevan108 commented Mar 2, 2019

Uh oh!

mmahadevan108 commented Mar 2, 2019

Uh oh!

mmahadevan108 commented Mar 2, 2019

Uh oh!

mmahadevan108 commented Mar 2, 2019

Uh oh!

mikisch81 commented Mar 2, 2019

Uh oh!

deepikabhavnani commented Mar 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ciarmcom commented Mar 2, 2019

Uh oh!

mikisch81 commented Mar 3, 2019

Uh oh!

mikisch81 commented Mar 3, 2019

Uh oh!

mikisch81 commented Mar 3, 2019

Uh oh!

NirSonnenschein commented Mar 4, 2019

Uh oh!

mikisch81 commented Mar 4, 2019

Uh oh!

mikisch81 commented Mar 8, 2019

Uh oh!

adbridge commented Mar 8, 2019

Uh oh!

mbed-ci commented Mar 8, 2019

Test run: SUCCESS

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

mmahadevan108 commented Mar 8, 2019

Uh oh!

Uh oh!

mmahadevan108 commented Mar 2, 2019 •

edited

Loading

deepikabhavnani commented Mar 2, 2019 •

edited

Loading