scancode: fix SPDX check - only warning #13782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the files failing in another PR: https://github.com/ARMmbed/mbed-os/blob/57a9d6e12c8e40434bfa34d39515ef614284b352/targets/TARGET_STM/TARGET_STM32H7/STM32Cube_FW/CMSIS/stm32h723xx.h The Travis job failing here : https://travis-ci.org/github/ARMmbed/mbed-os/jobs/736407744 |
ciarmcom
added
the
release-type: patch
|
@0xc0170, thank you for your changes. |
SPDX are not yet done in our codebase. We suggest them to be present but 3rd party drivers have not yet been updated. The check as it was causes problems when updating 3rd party drivers (red flags in the PR). Proper fix will be to clean up SPDX id in the codebase.
hugueskamba
force-pushed
the
fix_travis_scancode_spdx
branch
from
58ab133 to
61d88dd
Compare
hugueskamba
approved these changes
Oct 19, 2020
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
This was referenced Oct 19, 2020
| userlog.warning("Found files with missing SPDX identifier, please review and fix") | ||
| for offender in spdx_offenders: | ||
| userlog.warning("File: %s reason: %s" % (path_leaf(offender['path']), offender['fail_reason'])) | ||
| return len(license_offenders) |
There was a problem hiding this comment.
maybe len(license_offenders) + len(spdx_offenders) ?
mbedmain
added
release-version: 6.4.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
SPDX are not yet done in our codebase. We suggest them to be present but 3rd party
drivers have not yet been updated. The check as it was causes problems when updating
3rd party drivers (red flags in the PR).
Proper fix will be to clean up SPDX id in the codebase.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers