SysTimer: Prevent unacknowledged tick overflow when halted for a while #13867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@marcemmers, thank you for your changes. |
0xc0170
approved these changes
Nov 5, 2020
|
CI started (I already saw this fix in pelion and also proposed by @kjbracey-arm ) |
|
Thanks @marcemmers for fixing this. |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mikaleppanen
approved these changes
Nov 6, 2020
kjbracey
approved these changes
Nov 6, 2020
|
Why did CI fail for this? In the logs it says that greentea-test has passed everything. |
|
I'll restart CI (internal CI error) |
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.5.0
Release-pending
and removed
release-type: patch
jarvte
pushed a commit
to jarvte/mbed-os
that referenced
this pull request
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes
_unacknowledged_ticksfrom 8 to 32 bit to prevent overflow when interrupts are not being handled for a while.This could happen due to, for example, debugging or a long critical section.
Fixes #13801
Fixes #13772
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@kjbracey-arm