Skip to content

SysTimer: Prevent unacknowledged tick overflow when halted for a while #13867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

marcemmers
Copy link
Contributor

Summary of changes

Changes _unacknowledged_ticks from 8 to 32 bit to prevent overflow when interrupts are not being handled for a while.
This could happen due to, for example, debugging or a long critical section.

Fixes #13801
Fixes #13772

Impact of changes

Migration actions required

Documentation

None

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@kjbracey-arm

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 5, 2020
@ciarmcom ciarmcom requested review from kjbracey and a team November 5, 2020 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Nov 5, 2020

@marcemmers, thank you for your changes.
@kjbracey-arm @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from mikaleppanen November 5, 2020 15:18
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 5, 2020

CI started (I already saw this fix in pelion and also proposed by @kjbracey-arm )

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 5, 2020

Thanks @marcemmers for fixing this.

@mbed-ci
Copy link

mbed-ci commented Nov 5, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test

@marcemmers
Copy link
Contributor Author

Why did CI fail for this? In the logs it says that greentea-test has passed everything.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2020

I'll restart CI (internal CI error)

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 10, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 3555ada into ARMmbed:master Nov 11, 2020
@mergify mergify bot removed the ready for merge label Nov 11, 2020
@mbedmain mbedmain added release-version: 6.5.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 18, 2020
jarvte pushed a commit to jarvte/mbed-os that referenced this pull request Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventQueue timing errors when using tickless mode Writing to KVStore on DISCO-F769NI sets timers that are used on Mbed OS event queue out of sync
7 participants