Skip to content

[feature-wisun] Make _unacknowledged_ticks uint32_t to prevent overflow #13901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2020
Merged

[feature-wisun] Make _unacknowledged_ticks uint32_t to prevent overflow #13901

merged 1 commit into from
Nov 11, 2020

Conversation

mikaleppanen
Copy link

Summary of changes

Changes _unacknowledged_ticks from 8 to 32 bit to prevent overflow when interrupts are not being handled for a while.
This could happen due to, for example, debugging or a long critical section.

Fixes #13801
Fixes #13772

This is feature_wisun version of the pull request: #13867

Impact of changes

None

Migration actions required

None

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @artokin


@mikaleppanen
Copy link
Author

feature-wisun fix for the systick issue @amarjeet-arm @teetak01 @TuomoHautamaki

@ciarmcom ciarmcom requested review from artokin, mikter and a team November 11, 2020 10:30
@ciarmcom
Copy link
Member

@mikaleppanen, thank you for your changes.
@mikter @artokin @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 11, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 11, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 649ee6c into ARMmbed:feature-wisun Nov 11, 2020
@mergify mergify bot removed the ready for merge label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants