-
Notifications
You must be signed in to change notification settings - Fork 3k
Add debug symbols to release builds #2748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph test |
👍 |
Additionally, there should be a way to tell the build tools not to include the debug symbols, e.g. this patch makes it mandatory. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 900 All builds and test passed! |
that does not sound correct, I have been testing this patch locally, I provided numbers in the earlier PR, that this does not increase size 10x as it was ( mbed-lib (using
nucle f411re ARM:
What's the use case? the size of output is not that different, thus I don't think we need one more option for this to disable. I wouldn't want option for everything if really not required. |
@screamerbg I agree with @0xc0170 - I would not add an option to suppress debug information as it will be required for our build time statics and the overhead is negligible. If someone needs that for confidentiality reasons, they can still run |
@mbed-bot: TEST HOST_OSES=ALL |
I kicked off a test to see how it performs. I will be monitoring the CI machine just in case the size starts to explode. |
One consideration would be the mbed-sdk releases and how mbed online IDE can handle this increase in size. |
@0xc0170 can you provide numbers/sizes with the current flags, e.g. no debug |
The comment above, for K64F and NUCLEO F411RE build mbed lib with and without debug flags for ARMCC, paste here again:
|
[Build 951] |
We are planning to introduce compile profiles and this change can be introduced then. |
Replaces #2139, adding more flags for ARMCC to make the output smaller, now it should be 2x bigger than usual (more info in the referenced pull request).
All toolchains now produces output folders with acceptable sizes. Please review
@bogdanm @sg- @meriac @bridadan @screamerbg